New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Observer pattern possible future issues #30

Open

JayArrowz opened this issue Jun 11, 2021 · 0 comments

Labels

bug help wanted question

Owner

JayArrowz commented Jun 11, 2021 •

edited

Loading

The Message handlers currently support async functions:

.e.g.

NetScape/NetScape.Modules.FourSevenFour.Game/Messages/Handlers/WelcomeScreenHandler.cs

Line 22 in 12f629d

    
           public async Task OnWelcomeScreenClick(DecoderMessage<ClickButtonMessage> decoderMessage)

However if anything modifies the world state in a async manner and is not thread safe it could cause issues.

Anything executed in the message handlers has to be thread safe.

JayArrowz added bug help wanted question labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment