/is rewards - Unexpected behaviour

[jappamc]

Describe the bug
Multiple players are running into primarily 3 different unexpected behaviours when running /is rewards and attempting to claim.

• The mission reward disappears after an undetermined amount of time before the player can try to claim it from the GUI.
• Mission rewards disappear from the GUI if there are multiple rewards present, and any one of them is claimed.
• Mission rewards do not clear from the /is rewards GUI after claiming, and are able to be claimed infinitely.

To Reproduce
I'm unable to replicate this error, it seems to happen quite randomly and through my testing I haven't been able to make it happen for myself intentionally.

You'd expect the mission rewards to be present in the rewards GUI indefinitely until they are claimed, rather than disappearing or exhibiting any of the behaviours I've outlined above.

[16:38:34]: Plugin Name: IridiumSkyblock
[16:38:34]: Plugin Version: 4.0.9
[16:38:34]: Plugin Author: Peaches_MLG
[16:38:34]: Plugin Donations: www.patreon.com/Peaches_MLG

[16:38:43]: IridiumSkyblock version 4.0.9
[16:38:43]: Skyblock Redefined
[16:38:43]: Author: Peaches_MLG

Screenshots

Logs
https://mclo.gs/8sf5GtP

[LordOfTurk]

I have the same problem, unfortunately, I look at a player who has made a level 9000 island, the quest reward can be taken forever when it should be taken only 1 time, and the most crucial point is that it does not show any error on the console :/

[JamieNan]

I have experienced similar issues, with overlapping rewards disappearing, as well as being able to infinitely claim a reward. I haven't been able to successfully reproduce it and its occurence is random.

[SwierczKacper]

"Mission rewards do not clear from the /is rewards GUI after claiming, and are able to be claimed infinitely." - I can confirm this

[treasurebro123]

Yup happens with my server as well. Is this plugin dead now? This is a game breaking bug and its been almost a year and still "unconfirmed" what lol.

[boiscljo]

Yup happens with my server as well. Is this plugin dead now? This is a game breaking bug and its been almost a year and still "unconfirmed" what lol.

It is unconfirmed because our team cannot reproduce it. We tested everything on our test servers and it never happened. And without knowing what caused it (reproducable) we can`t confirm or fix it

[treasurebro123]

Ah I see now. I just noticed that there wasn't an update in the modrinth plugin site for a couple months and seeing that tag threw me off thanks for explaining the situation to me!

[Annie-I]

Hello!
I also have this issue with missions that I created.
Server Plugins (6): CommandItems, Vault, AuraSkills, Essentials, EssentialsSpawn, IridiumSkyblock

Issues:

1. If I don't claim the reward for mission that has several iterations (1, 2, 3, ...), it gets overwritten by next reward and I end up only with the last reward.
2. Sometimes I can collect a reward infinitely.

Please tell me how I can help, what has to be provided in order for you to be able to fix this.

[sh0inx]

@Annie-I we need a reliable way to reproduce these issues.

In order for us to determine what's causing the issue, we need to identify how the problem is occurring, which we can only do if we can replicate the issue.

[Annie-I]

What I did to recreate mission reward rewrite issue:

1. Create https://scalacube.com game server with spigot version 1.20
2. Install Vault plugin (version 1.7.3 )
3. Install IridiumSkyblock plugin (version 4.0.9.1)
4. Install EssentialsX plugin (version 2.21.0-dev+129-2ac37d8)
5. Give yourself admin
6. /economy give {username} 1000
7. /is create
8. Choose jungle island
9. Replace server > plugins > IridiumSkyblock > missions.yml content with text from
   missions.txt
10. Reboot server
11. Create cobblestone generator
12. Complete "expert miner" missions
13. Check rewards and see that only 3rd reward is collectable https://www.loom.com/share/549371304d234507a7ed31b32b33f667?sid=e81040cc-f7a7-44c8-b6d8-786ad0d06b98
14. Check money and island crystals and see that indeed only 3rd mission reward was collected

[PeachesMLG]

What I did to recreate mission reward rewrite issue:

1. Create https://scalacube.com game server with spigot version 1.20

2. Install Vault plugin (version 1.7.3 )

3. Install IridiumSkyblock plugin (version 4.0.9.1)

4. Install EssentialsX plugin (version 2.21.0-dev+129-2ac37d8)

5. Give yourself admin

6. /economy give {username} 1000

7. /is create

8. Choose jungle island

9. Replace server > plugins > IridiumSkyblock > missions.yml content with text from
   [missions.txt](https://github.com/user-attachments/files/17882345/missions.txt)

10. Reboot server

11. Create cobblestone generator

12. Complete "expert miner" missions

13. Check rewards and see that only 3rd reward is collectable [https://www.loom.com/share/549371304d234507a7ed31b32b33f667?sid=e81040cc-f7a7-44c8-b6d8-786ad0d06b98](url)

14. Check money and island crystals and see that indeed only 3rd mission reward was collected

This is slightly different to the issue being discuessed here, but I have fixed it in #930

[PeachesMLG]

#930 has also patched the other issue