Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine Bootstrap State Machine to ignore local peers when it should #974

Closed
nfrisby opened this issue Feb 28, 2024 · 0 comments · Fixed by #1091
Closed

Refine Bootstrap State Machine to ignore local peers when it should #974

nfrisby opened this issue Feb 28, 2024 · 0 comments · Fixed by #1091

Comments

@nfrisby
Copy link
Contributor

nfrisby commented Feb 28, 2024

IntersectMBO/ouroboros-network#4815 would allow the Bootstrap State Machine to distinguish remote from local peers, which is sometimes crucial. See that issue for more details on what the GSM code (introduced in #808) should do once that information is available.
@nfrisby nfrisby moved this to 🚫 Help needed in Consensus Team Backlog Feb 28, 2024
amesgen added a commit that referenced this issue May 8, 2024
@amesgen
GSM: use diffusion layer info for HAA
4946b3b 
Concretely, this addresses
#974 in the context of
bootstrap peers, but this code will also work for the "actual" Honest
Availability Assumption of Genesis once implemented on the Network side.
@amesgen amesgen moved this from 🚫 Help needed to 🏗 In progress in Consensus Team Backlog May 8, 2024
@amesgen amesgen moved this from 🏗 In progress to 👀 In review in Consensus Team Backlog May 8, 2024
@amesgen amesgen mentioned this issue May 8, 2024
Merged
Lucsanszky added a commit that referenced this issue May 9, 2024
@Lucsanszky
Account for ouroboros-network changes
3f873d6 
* Update `ouroboros-consensus-diffusion` to `ouroboros-network-0.16.0.0`

* GSM: use diffusion layer info for HAA
  Concretely, this addresses
  #974 in the context of
  bootstrap peers, but this code will also work for the "actual" Honest
  Availability Assumption of Genesis once implemented on the Network side.

* BootstrapPeers.md: include pseudo-HAA

* Remove `ShowProxy` instance of `SlotNo`
  It is now provided by `ouroboros-network`.
github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
@amesgen
Updated ouroboros-consensus-diffusion to `ouroboros-network-0.16.0.…
73d18f3 
…0` (#1091)

Closes #974
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Consensus Team Backlog May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Consensus Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated ouroboros-consensus-diffusion to ouroboros-network-0.16.0.0 IntersectMBO/ouroboros-consensus
1 participant
@nfrisby