Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the response body in the network logs when using Swift Concurrency #487

Open
xmollv opened this issue Mar 18, 2024 · 6 comments
Open

Comments

@xmollv
Copy link

xmollv commented Mar 18, 2024

This is a known issue related to #482. See comment: #482 (comment).

Steps to Reproduce the Problem

  1. Perform any network request using Swift Concurrency (async/await)
  2. Trigger a bug report and submit it to Instabug
  3. Observe how the network request is properly logged (when using Instabug 12.9.0 or newer), but the response body is missing
image

Expected Behavior

We're able to inspect the response body the server gave us.

Actual Behavior

Only the response header's are logged, the body is missing.

Instabug integration code

287971155-20e41fae-9429-4259-8a2e-b2f0d8a3fd9d

SDK Version

12.9.0

iOS Version

iOS 17.4

Device Model

iPhone 15 Pro

@xmollv
Copy link
Author

xmollv commented Mar 25, 2024

@ahmedsalah196 just a ping because this ticket doesn't seem to have been triaged yet!

@ahmedsalah196
Copy link
Contributor

@xmollv We don't have plans to support this at the current time. Will state this in our public docs soon

@ahmedsalah196 ahmedsalah196 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
@xmollv
Copy link
Author

xmollv commented Mar 26, 2024

@ahmedsalah196 is not going to be supported because there's no way to automatically capture responses? I'm more than happy to decode the response myself and include them on Instabug manually. Is there a possibility to add an API on Instabug's SDK to achieve that?

@ahmedsalah196
Copy link
Contributor

@xmollv I will check this with our product team and get back to you

@shankha-archives
Copy link

When is this going to resolve ??

@xmollv
Copy link
Author

xmollv commented Aug 16, 2024

@ahmedsalah196 @EyadHeikal Could we please reopen this ticket and add the 'Feature Request' label? Ignoring this sends a strong message about Instabug not being able to keep up with the latest technologies on iOS.

@xmollv xmollv changed the title Include the response body in the network logs when using Swift Concurrency [Feature Request] Include the response body in the network logs when using Swift Concurrency Aug 16, 2024
@ahmedsalah196 ahmedsalah196 reopened this Aug 19, 2024
@xmollv xmollv changed the title [Feature Request] Include the response body in the network logs when using Swift Concurrency Include the response body in the network logs when using Swift Concurrency Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants