Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package version number #95

Open
fbudin69500 opened this issue Jan 31, 2018 · 2 comments
Open

Package version number #95

fbudin69500 opened this issue Jan 31, 2018 · 2 comments

Comments

@fbudin69500
Copy link

fbudin69500 commented Jan 31, 2018

Currently, the package version number is fetched with git describe, but this means that it uses the last tag, which may not be the current tag for new major releases. As an example, the current Python packages are names 4.13.xxxx when the current ITK_VERSION is 5.0.0 which is confusing. A better way to name the packages would be to name them based on the ITK_VERSION variable in the ITK CMakeLists.txt . Following PEP440, the name of the nightly packages could be: ${ITK_VERSION_MAJOR}.${ITK_VERSION_MINOR}.${ITK_VERSION_PATCH}a${sha}, or something similar.

@jcfr
Copy link
Contributor

jcfr commented Jan 31, 2018

Good point.

If current commit is NOT a tag, I suggest to create a developmental pre release following this pattern:

X.YrcN.devM

where:

  • X.Y would be set to 5.0. It could be extracted from the CMake script using a regex
  • N in rcN would be set to the number of commit since last release (variable numberOfCommits in scripts/update_python_version.py)
  • M in devM would be set to the date of the last commit

@thewtex
Copy link
Member

thewtex commented Jun 5, 2024

scikit-build-core's dynamic metadata support will help here:

https://scikit-build-core.readthedocs.io/en/latest/configuration.html#dynamic-metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants