From 81103e064186785fa34a17d9cde42840b4d1347a Mon Sep 17 00:00:00 2001 From: Weiqun Zhang Date: Mon, 24 Jul 2023 11:49:14 -0700 Subject: [PATCH] Intel CI: Update Warning Flags (#3443) No need for -Wno-missing-brace and -Wno-sign-compares anymore. These warnings in MKL have been fixed in oneAPI 2023.2.0. --- .github/workflows/intel.yml | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/.github/workflows/intel.yml b/.github/workflows/intel.yml index 3f16341f388..79e0df57391 100644 --- a/.github/workflows/intel.yml +++ b/.github/workflows/intel.yml @@ -24,9 +24,7 @@ jobs: restore-keys: | ccache-${{ github.workflow }}-${{ github.job }}-git- - name: Build & Install - # mkl/rng/device/detail/mrg32k3a_impl.hpp has a number of sign-compare error - # mkl/rng/device/detail/mrg32k3a_impl.hpp has missing braces in array-array initalization - env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-sign-compare -Wno-missing-braces"} + env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor"} run: | export CCACHE_COMPRESS=1 export CCACHE_COMPRESSLEVEL=10 @@ -69,9 +67,7 @@ jobs: restore-keys: | ccache-${{ github.workflow }}-${{ github.job }}-git- - name: Build & Install - # mkl/rng/device/detail/mrg32k3a_impl.hpp has a number of sign-compare error - # mkl/rng/device/detail/mrg32k3a_impl.hpp has missing braces in array-array initalization - env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-sign-compare -Wno-missing-braces"} + env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor"} run: | export CCACHE_COMPRESS=1 export CCACHE_COMPRESSLEVEL=10 @@ -120,10 +116,8 @@ jobs: ccache-${{ github.workflow }}-${{ github.job }}-git- - name: Build & Install if: ${{ env.CODEPLAYTOKEN != '' }} - # mkl/rng/device/detail/mrg32k3a_impl.hpp has a number of sign-compare error - # mkl/rng/device/detail/mrg32k3a_impl.hpp has missing braces in array-array initalization # clang currently supports CUDA up to version 11.5 and a warning is issued with newer versions - env: {CXXFLAGS: "-fsycl -fsycl-targets=nvptx64-nvidia-cuda -fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-sign-compare -Wno-missing-braces -Wno-unknown-cuda-version"} + env: {CXXFLAGS: "-fsycl -fsycl-targets=nvptx64-nvidia-cuda -fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-unknown-cuda-version"} run: | export CCACHE_COMPRESS=1 export CCACHE_COMPRESSLEVEL=10 @@ -172,9 +166,7 @@ jobs: ccache-${{ github.workflow }}-${{ github.job }}-git- - name: Build & Install if: ${{ env.CODEPLAYTOKEN != '' }} - # mkl/rng/device/detail/mrg32k3a_impl.hpp has a number of sign-compare error - # mkl/rng/device/detail/mrg32k3a_impl.hpp has missing braces in array-array initalization - env: {CXXFLAGS: "-fsycl -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx90a -fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-sign-compare -Wno-missing-braces"} + env: {CXXFLAGS: "-fsycl -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx90a -fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor"} run: | export CCACHE_COMPRESS=1 export CCACHE_COMPRESSLEVEL=10