Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18.2 Modified Armor Values Not Showing Changed #8

Open
AetheriMC opened this issue Jun 6, 2022 · 5 comments
Open

1.18.2 Modified Armor Values Not Showing Changed #8

AetheriMC opened this issue Jun 6, 2022 · 5 comments

Comments

@AetheriMC
Copy link

Minecraft Forge v1.18.2-forge-40.1.0
Property Modifier v1.18.2-0.1

Issue: Modified armor values within the config are not being reflected within the actual game. In testing this, we used several different modded armors and updated their armor values from default to 0, however armors modified in this way continued to show default armor values in both the item's description and on the player's armor hotbar display when worn. We did not test non-zero values or vanilla armors.

A weird side note here. While PM did not seem to have an outward affect on the listed armor values for the items we tested, it is possible that the actual armor benefits for the armors reduced to 0 worked as intended. I don't know this for certain, but we have a mod that lets us selectively prevent players from wearing items with an armor value above 0. Armors that were previously unwearable because of this mod, once modified by PM, were actually able to be worn in spite of their listed values and hotbar displays still registering that the item had armor. I'm not sure this information is helpful, but suffice it to say that PM is modifying something. More testing is required.

We appreciate your efforts in making/updating this mod!

@AetheriMC
Copy link
Author

Adding to this. The mod seems to work for vanilla armor attributes but isn't working for modded armor attributes.

@RedBeast1959
Copy link

Same problem happens in 1.19.2 version(propertymodifier-1.19.2-0.1.jar). Modded armor attributes doesn't work.

@IchHabeHunger54
Copy link
Owner

Could I see both of your config files, please?

@IchHabeHunger54
Copy link
Owner

Please try updating, both of you. The latest versions should have this problem fixed.

@IchHabeHunger54
Copy link
Owner

Please confirm this issue is still relevant, otherwise it will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants