New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limitation to setting the stack size #20

Open

SiverDX opened this issue Nov 11, 2023 · 0 comments

SiverDX commented Nov 11, 2023

Why does this exist

PropertyModifier/src/main/java/ihh/propertymodifier/Config.java

Line 312 in a4d8ede

    
           Logger.error("Cannot set the max stack size value for non-damageable item " + item);

If you are worried about modifying items which can get damaged you could use the check vanilla does

public Item.Properties stacksTo(int pMaxStackSize) {
   if (this.maxDamage > 0) {
      throw new RuntimeException("Unable to have damage AND stack.");
   } else {
      this.maxStackSize = pMaxStackSize;
      return this;
   }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment