Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Better handling of dual #7

Open
ogauthe opened this issue Jan 6, 2025 · 1 comment
Open

[ENHANCEMENT] Better handling of dual #7

ogauthe opened this issue Jan 6, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@ogauthe
Copy link
Collaborator

ogauthe commented Jan 6, 2025

To produce a singlet, the domain and codomain must fuse to dual sectors. Currently, both domain and codomain are fused on the same sector. The flip on the domain should be explicit.

@ogauthe ogauthe added the enhancement New feature or request label Jan 6, 2025
@lkdvos lkdvos closed this as completed Jan 8, 2025
@lkdvos lkdvos reopened this Jan 8, 2025
@ogauthe
Copy link
Collaborator Author

ogauthe commented Jan 23, 2025

I pushed a commit where I explicitly flip the domain fusion tree. I am not entirely satisfied with it, but internal consistency imposes several constraints:

  • the data_matrix has to be diagonal (being off diagonal is very confusing)
  • it imposes a given order for sectors
  • I do not want to have completely different code paths for domain and codomain

I am not settled yet whether I prefer the new version or the old one, I am not sure it is much more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants