combine endpoints; deprecate old search endpoint and update readme #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkim312
requested changes
Jan 15, 2025
|
|
||
| if (queryMap.isEmpty()) { | ||
| if (searchText != null && !searchText.isEmpty()) { | ||
| Project project = this.projectDAO.getProjectById(searchText); |
There was a problem hiding this comment.
Just curious. Is there any occasion that the searchText is null but searchText is not empty or the other way around?
There was a problem hiding this comment.
oh the other way, sometimes text could be empty string ""
| if (project != null) { | ||
| projects.add(project); | ||
| } else { | ||
| projects = this.projectDAO.searchProjects(searchText); |
There was a problem hiding this comment.
what if this projects is also null?
There was a problem hiding this comment.
I think the search function will always return list, if not found then empty list.
@Override
public List<Project> searchProjects(String text) {
Query<Project> query = this.dataStore.find(Project.class).filter(
Filters.or(
Filters.regex(PROJECT_FIELD_NAME).pattern(text).caseInsensitive(),
Filters.regex(PROJECT_FIELD_DESCRIPTION).pattern(text).caseInsensitive(),
Filters.regex(PROJECT_FIELD_CREATOR).pattern(text).caseInsensitive(),
Filters.regex(PROJECT_FIELD_OWNER).pattern(text).caseInsensitive(),
Filters.regex(PROJECT_FIELD_REGION).pattern(text).caseInsensitive()
));
return query.iterator().toList();
}
```
...ce/src/main/java/edu/illinois/ncsa/incore/service/project/controllers/ProjectController.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/edu/illinois/ncsa/incore/service/project/controllers/ProjectController.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/edu/illinois/ncsa/incore/service/project/controllers/ProjectController.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/edu/illinois/ncsa/incore/service/project/controllers/ProjectController.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/edu/illinois/ncsa/incore/service/project/controllers/ProjectController.java
Outdated
Show resolved
Hide resolved
ywkim312
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.