Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle states being applied to invalid roles #1

Open
Snugug opened this issue Oct 21, 2014 · 1 comment
Open

Handle states being applied to invalid roles #1

Snugug opened this issue Oct 21, 2014 · 1 comment

Comments

@Snugug
Copy link
Member

Snugug commented Oct 21, 2014

Something not added in the initial release that I would like input into is how to handle states being applied to invalid roles. In the states object, I have a property used that I intend to use to do the validation. It currently contains all of the Used in Roles roles, but not the Inherits into Roles roles (although it could be updated to include them).

So, all that in mind, should this check to make sure it's being applied to a valid role? If so, what should the expected functionality be if a state is being applied to an invalid role? To an item without a role? Should a state that can be applied to any role is being applied to an item without a role, should the errors still pop up?

@jessebeach
Copy link

Should a state that can be applied to any role is being applied to an item without a role, should the errors still pop up?

console.info is probably appropriate here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants