Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LangDefs causing save issues #152

Closed
ProgramComputer opened this issue Oct 4, 2023 · 2 comments
Closed

LangDefs causing save issues #152

ProgramComputer opened this issue Oct 4, 2023 · 2 comments

Comments

@ProgramComputer
Copy link

ProgramComputer commented Oct 4, 2023

Describe the bug
Langdefs is not updated when unsupported languages are added and searches by a few demo lang names unrecognized.
To Reproduce
Load the Demo in db
Try to save in TTS Speech settings.

Expected behavior
Cookies will exist

Server (please complete)
Linux install. Ran install.sh.

Additional context
Chinese and Chinese2 have both undefined array keys as it does not match traditional and simplified strings.
Maybe linked to #113 if so close.

@HugoFara
Copy link
Owner

HugoFara commented Oct 4, 2023

Hi! Thank you for the suggestion, using cookies may be a nice way to solve the issue (I will have a deeper look at the code later on).

Langdefs was integrated incrementally in the code, it still needs some layers of refinement to cover all the options and use cases.

@ProgramComputer
Copy link
Author

ProgramComputer commented Oct 7, 2023

I meant for testing the issue. Cookies that were supposed to be set in Text-To-Speech will not show because it calls langdefs and blocks it.

return $langDefs[$language][1];
. I'm not suggesting to use cookies.

@ProgramComputer ProgramComputer closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants