Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove traits FieldBasedSignatureScheme and FieldBasedVrf #86

Open
UlrichHaboeck75 opened this issue Mar 19, 2021 · 0 comments
Open

Remove traits FieldBasedSignatureScheme and FieldBasedVrf #86

UlrichHaboeck75 opened this issue Mar 19, 2021 · 0 comments
Labels
sw design SW design choice to be made or implemented

Comments

@UlrichHaboeck75
Copy link

The traits FieldBasedSignatureScheme and FieldBasedVrf where introduced by us for our circuit-friendly variants of the Schnorr Signature (the FieldBasedSchnorrSignature) and our Schnorr-NIZK based VRF.
Regarding FieldBasedSignatureScheme I do not see any reason for having this extra trait. The circuit-friendly Schnorr is just another "normal" signature scheme, and hence comes with no additional/different trait functions.
Similarly for the VRF. I'd opt for introducing a general trait VRF without the "FieldBased".
@UlrichHaboeck75 UlrichHaboeck75 added the sw design SW design choice to be made or implemented label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sw design SW design choice to be made or implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UlrichHaboeck75