Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small errors in endo mul #171

Open
DanieleDiBenedetto opened this issue Feb 17, 2022 · 0 comments
Open

Small errors in endo mul #171

DanieleDiBenedetto opened this issue Feb 17, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@DanieleDiBenedetto
Copy link
Collaborator

DanieleDiBenedetto commented Feb 17, 2022

A couple of errors with the endo mul must be fixed:

  1. Tests (both for primitive and gadget) for Tweedle are wrong, as they consider the first 128 bits of the scalar, while they should consider the last (first are all 0s) (already addressed as part of 344d45f )
  2. Like we did for mul_bits and mul_bits_fixed_base, would be nice to add a function that checks the inputs and returns error if they are not valid (e.g. trivial base point)
  3. Let's change the interfaces to not accept Vec<bool> but Iterator<bool> (avoid unnecessary cloning)
@DanieleDiBenedetto DanieleDiBenedetto added the bug Something isn't working label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant