Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gempyor: remove dependencies on config when creating setup #20

Closed
jcblemai opened this issue Mar 31, 2023 · 1 comment
Closed

Gempyor: remove dependencies on config when creating setup #20

jcblemai opened this issue Mar 31, 2023 · 1 comment

Comments

@jcblemai
Copy link
Collaborator

  • keep them so we can change parameters easily
  • but makes them non-mandatory so config changes are easy.
@jcblemai
Copy link
Collaborator Author

jcblemai commented Oct 3, 2023

This is fixed in #72, where the setup object (now called model_info) is the only user of the config.

@jcblemai jcblemai closed this as completed Oct 3, 2023
@jcblemai jcblemai added this to the Paper resubmission milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant