Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exact versions for vscode plugins #1273

Closed
sobolevn opened this issue Dec 19, 2023 · 2 comments
Closed

Support exact versions for vscode plugins #1273

sobolevn opened this issue Dec 19, 2023 · 2 comments
Labels

Comments

@sobolevn
Copy link

Hi! Thanks a lot for supporting vscode in Brewfile, this is really helpful.

Right now brew dumps all plguins without their versions, but sometimes vscode plugins require a specific version due to some changes in them.

vscode already support installing specific versions of plugins and listing the version.

Right now I have to skip vscode in Brewfile and keep a separate file with code --install-extension 'ext@version' calls. Which is not very convenient :(

My proposal is:

It should just work after that:

--install-extension <ext-id | path>   Installs or updates an extension. The argument is
                                      either an extension id or a path to a VSIX. The
                                      identifier of an extension is
                                      '${publisher}.${name}'. Use '--force' argument to
                                      update to latest version. To install a specific
                                      version provide '@${version}'. For example:
                                      '[email protected]'.

What do others think?

@jacobbednarz
Copy link
Contributor

this goes against Homebrew and homebrew/bundle in general so very unlikely and not something I can see being included. see the note in the README on versions for more details.

@jacobbednarz jacobbednarz closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
@sobolevn
Copy link
Author

As a workaround you can just do that manually:

#!/usr/bin/env bash

set -e

# Brewfile does not support dumping exact versions by default.
# So, here are some exact versions of plugins that I use
# (when I care about the version).
sd -s 'vscode "teabyii.ayu"' 'vscode "[email protected]"' Brewfile

echo 'Brewfile updated'

This can be added to pre-commit hooks as well.
Works like a charm :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants