Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize order of tensor dimensions #80

Open
Waino opened this issue Nov 4, 2024 · 0 comments
Open

Standardize order of tensor dimensions #80

Waino opened this issue Nov 4, 2024 · 0 comments

Comments

@Waino
Copy link
Collaborator

Waino commented Nov 4, 2024

OpenNMT uses the order seq batch dim, while x-transformers uses batch seq dim. Currently, we transpose tensors to limit the x-transformers order to the parts where it is strictly necessary, while retaining the OpenNMT order everywhere else.

To simplify the code and avoid unnecessary transposes, we should use batch seq dim everywhere, starting from the data loader all the way through to the translation decoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant