Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an apdu protocol version #51

Open
r4mmer opened this issue Feb 10, 2022 · 0 comments
Open

Create an apdu protocol version #51

r4mmer opened this issue Feb 10, 2022 · 0 comments

Comments

@r4mmer
Copy link
Member

r4mmer commented Feb 10, 2022

Summary

The wallet has no way of knowing if a version of the app is compatible with it. We don't want users to update their wallets for every Ledger update, it should be up to the user even if it's recommended.

Current Solution

The current solution adopted is to choose an arbitrary Ledger app version that the wallet does not support and if we implement any breaking changes we should bump to that version.
For now the wallet assumes a bump on major will break compatibility but this is not ideal since if we would want to just patch anything on the protocol we'd need to do a major bump.

Proposed solution

Create a protocol version control that is separate from app version.
The protocol version can be a simple number or follow semantic versioning.
This protocol version should be how the wallet knows it can interact with the Ledger app as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant