Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device-port] [espresso3g/espressowifi] Samsung Galaxy Tab 2 #238

Open
7 of 15 tasks
MightyM17 opened this issue Jan 16, 2021 · 146 comments
Open
7 of 15 tasks

[device-port] [espresso3g/espressowifi] Samsung Galaxy Tab 2 #238

MightyM17 opened this issue Jan 16, 2021 · 146 comments

Comments

@MightyM17
Copy link

MightyM17 commented Jan 16, 2021

Tree: halium-7.1

  • Create manifest
  • Boot image and system image build successfully
  • Device boots into rootfs, usb: Manufacturer: GNU/Linux Device appears in dmesg on host.
  • LXC container starts and does not crash
  • libhybris tests
    • test_gps
phablet@ubuntu-phablet:~$  test_gps
*** setup signal handler
*** get gps interface
*** device info
 id = gps
 name = gps.samsungP6android
 author = SAMSUNG ELECTRONICS Co.,Ltd
*** init gps interface
 ** Creating thread: 'IPC Thread' (start=0xb69b6dd5, arg=(nil))
 ** After thread_create: 'IPC Thread', error=0 (start=0xb69b6dd5, arg=(nil))
*** setting positioning mode
 **** Thread wrapper start (start=0xb69b6dd5, arg=(nil)) ****
*** start gps track
*** gps tracking started
*** tracking....
^C*** cleanup
*** status callback
*** session end
*** status callback
*** engine off
  • test_hwcomposer
phablet@ubuntu-phablet:~$ test_hwcomposer
test_hwcomposer: test_hwcomposer.cpp:185: int main(int, char**): Assertion `err == 0' failed.
Aborted
  • test_lights
phablet@ubuntu-phablet:~$ test_lights
test_lights: test_lights.c:34: main: Assertion `notifications != NULL' failed.
Aborted
  • test_vibrator
phablet@ubuntu-phablet:~$ test_vibrator
test_vibrator is not supported in this build
  • test_wifi
phablet@ubuntu-phablet:~$ test_wifi
To load driver: test_wifi 1
To unload driver: test_wifi 0
WiFi driver load state: 0
  • test_sensors
phablet@ubuntu-phablet:~$ test_sensors
Hardware module ID: sensors
Hardware module Name: Galaxy Tab 2 Sensor Module
Hardware module Author: Daniel Jarai
Hardware module API version: 0x1
Hardware HAL API version: 0x100
Poll device version: 0x1000001
API VERSION 0.1 (legacy): 0x1
API VERSION 0.1: 0x65537
API VERSION 1.0: 0x16777217
API VERSION 1.1: 0x16842753
API VERSION 1.2: 0x16908289
API VERSION 1.3: 0x16973825
API VERSION 1.4: 0x17039361
Got 5 sensors
=== Sensor 0 ==
Name: BMA254 Acceleration Sensor
Vendor: Bosch Sensortec
Version: 0x1
Handle: 0x1
Type: 1
maxRange: 19.613300
resolution: 0.38307
power: 0.129999 mA
minDelay: 0



=== Sensor 1 ==
Name: MS-3E (YAS530) Magnetic Sensor
Vendor: Yamaha Corporation
Version: 0x1
Handle: 0x2
Type: 2
maxRange: 800.0
resolution: 0.300000
power: 4.0 mA
minDelay: 10000



=== Sensor 2 ==
Name: MS-x Orientation Sensor
Vendor: Yamaha Corporation
Version: 0x1
Handle: 0x3
Type: 3
maxRange: 360.0
resolution: 0.100000
power: 0.0 mA
minDelay: 10000



=== Sensor 3 ==
Name: GP2AP002 Light Sensor
Vendor: Sharp
Version: 0x1
Handle: 0x4
Type: 5
maxRange: 0.0
resolution: 0.0
power: 0.0 mA
minDelay: 0



=== Sensor 4 ==
Name: GP2AP002 Proximity Sensor
Vendor: Sharp
Version: 0x1
Handle: 0x5
Type: 8
maxRange: 5.0
resolution: 0.0
power: 0.0 mA
minDelay: 0
  • test_audio
phablet@ubuntu-phablet:~$ test_audio
Audio device API version 0200 doesn't match platform current 3004.test_audio: test_audio.c:71: main: Assertion `audiohw->common.version == AUDIO_DEVICE_API_VERSION_CURRENT' failed.
Aborted
  • test_camera
phablet@ubuntu-phablet:~$ test_camera
Problem connecting to camera
  • test_input
phablet@ubuntu-phablet:~$ test_input
fatal error opening "/sys/power/wake_lock": Permission denied
fatal error opening "/sys/android_power/acquire_partial_wake_lock": No such file or directory
  • test_recorder
^Cphablet@ubuntu-phablet:~$ test_recorder
Test application for video recording using the camera
Recording start with volume up button. And stops with volume down.
The result is stored to /root/test_video.avi
@MightyM17
Copy link
Author

MightyM17 commented Jan 16, 2021

I am getting this error
https://pastebin.com/WbRiSAFr

Edit - Fixed it by changing fstab.espresso

@MightyM17
Copy link
Author

MightyM17 commented Jan 17, 2021

halium-boot.img is too big, Any fixes for that?

Edit - use Heimdall (?)

@lloowen
Copy link

lloowen commented Jan 20, 2021

MightyM17 have you succeeded in porting Samsung Galaxy Tab2 10.1 p5110 ?

@MightyM17
Copy link
Author

MightyM17 have you succeeded in porting Samsung Galaxy Tab2 10.1 p5110 ?

Not yet, i was trying with a 3.4 kernel but i have found a 3.8 kernel so im working with itnow

@lloowen
Copy link

lloowen commented Jan 21, 2021

Just started learning how Halium works. So I'm on the first stage of the list shown above. Would be very grateful for some pointers.
I thought p5110 needed halium-5.1 as the original Android version was lower than Android 7.1
I used the information from this link to build the manifest file but I can't get past the mka mkbootin stage

@MightyM17
Copy link
Author

It is pretty easy you just need to follow the guide.

I used the information from this link to build the manifest file but I can't get past the mka mkbootin stage

what is your error can you paste it to pastbin or something?

@MightyM17
Copy link
Author

For Update - halium-boot.img has some issues only with ubuntu touch's defconfig edit. In my testing I could install halium-boot.img and the rootfs but my pc cant detect the tab and it shows a blank screen

@MightyM17
Copy link
Author

@lloowen
Copy link

lloowen commented Jan 22, 2021

It is pretty easy you just need to follow the guide.

I used the information from this link to build the manifest file but I can't get past the mka mkbootin stage

what is your error can you paste it to pastbin or something?

I started again from scratch, this time using the Halium-7.1 tree. I have also gone through the halium documentation using the android_device_samsung_espressowif. But I'm stuck again on with the mka mkbooting. I'm getting this output:

~/HALIUM$ mka mkbooting
make: Entering directory '/home/lloowen/HALIUM'
build/core/product_config.mk:249: *** Can not locate config makefile for product "aosp_arm". Stop.
make: Leaving directory '/home/lloowen/HALIUM'

The biggest problem I have right now is understanding the directory structure of Halium and how it relates to git repositories as well as the file system and directory structure of the hardware.

@MightyM17
Copy link
Author

Looks like your xml file isnt proper can u send it here?

@MightyM17
Copy link
Author

Okay so new start, i will try with Unlegacy-Android/OMAP4-AOSP sources, here is a 3.10 wip kernel https://github.com/OMAP4-AOSP/android_kernel_samsung_espresso/

@MightyM17
Copy link
Author

There were many changes i needed to do locally! for now i am stuck at mka halium-boot

mka halium-boot
make: Entering directory '/home/mighty/Halium'
============================================
PLATFORM_VERSION_CODENAME=REL
PLATFORM_VERSION=7.1.1
LINEAGE_VERSION=
TARGET_PRODUCT=aosp_espresso3g
TARGET_BUILD_VARIANT=userdebug
TARGET_BUILD_TYPE=release
TARGET_BUILD_APPS=
TARGET_ARCH=arm
TARGET_ARCH_VARIANT=armv7-a-neon
TARGET_CPU_VARIANT=cortex-a9
TARGET_2ND_ARCH=
TARGET_2ND_ARCH_VARIANT=
TARGET_2ND_CPU_VARIANT=
HOST_ARCH=x86_64
HOST_2ND_ARCH=x86
HOST_OS=linux
HOST_OS_EXTRA=Linux-5.8.0-41-generic-x86_64-with-Ubuntu-20.04-focal
HOST_CROSS_OS=windows
HOST_CROSS_ARCH=x86
HOST_CROSS_2ND_ARCH=x86_64
HOST_BUILD_TYPE=release
BUILD_ID=NOF27B
OUT_DIR=/home/mighty/Halium/out
============================================
halium/hybris-boot/Android.mk:69: ********************* /boot appears to live on /dev/block/platform/omap_hsmmc.1/by-name/KERNEL
halium/hybris-boot/Android.mk:70: ********************* /data appears to live on /dev/block/platform/omap_hsmmc.1/by-name/DATAFS
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Argon.ogg:system/media/audio/alarms/Argon.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Carbon.ogg:system/media/audio/alarms/Carbon.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Krypton.ogg:system/media/audio/alarms/Krypton.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Neon.ogg:system/media/audio/alarms/Neon.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Osmium.ogg:system/media/audio/alarms/Osmium.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Platinum.ogg:system/media/audio/alarms/Platinum.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/Effect_Tick_48k.ogg:system/media/audio/ui/Effect_Tick.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressDelete_120_48k.ogg:system/media/audio/ui/KeypressDelete.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressReturn_120_48k.ogg:system/media/audio/ui/KeypressReturn.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressSpacebar_120_48k.ogg:system/media/audio/ui/KeypressSpacebar.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressStandard_120_48k.ogg:system/media/audio/ui/KeypressStandard.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressInvalid_120_48k.ogg:system/media/audio/ui/KeypressInvalid.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/LowBattery.ogg:system/media/audio/ui/LowBattery.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/Trusted_48k.ogg:system/media/audio/ui/Trusted.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/VideoRecord_48k.ogg:system/media/audio/ui/VideoRecord.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/VideoStop_48k.ogg:system/media/audio/ui/VideoStop.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/WirelessChargingStarted.ogg:system/media/audio/ui/WirelessChargingStarted.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/camera_click_48k.ogg:system/media/audio/ui/camera_click.ogg ignored.
build/core/Makefile:34: warning: overriding recipe for target '/home/mighty/Halium/out/target/product/espresso3g/system/lib/libsecnativefeature.so'
build/core/base_rules.mk:316: warning: ignoring old recipe for target '/home/mighty/Halium/out/target/product/espresso3g/system/lib/libsecnativefeature.so'
No private recovery resources for TARGET_DEVICE espresso3g
Building Kernel
make  CFLAGS_MODULE="-fno-pic" -C kernel/samsung/espresso O=/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ ARCH=arm CROSS_COMPILE="/usr/bin/ccache arm-linux-androidkernel-" zImage
make[1]: Entering directory '/home/mighty/Halium/kernel/samsung/espresso'
  GEN     /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/Makefile
  CHK     include/generated/uapi/linux/version.h
  CC      scripts/mod/devicetable-offsets.s
  GEN     scripts/mod/devicetable-offsets.h
  HOSTCC  scripts/mod/file2alias.o
  Using /home/mighty/Halium/kernel/samsung/espresso as source for kernel
  CHK     include/generated/utsrelease.h
make[3]: 'include/generated/mach-types.h' is up to date.
  CALL    /home/mighty/Halium/kernel/samsung/espresso/scripts/checksyscalls.sh
  HOSTLD  scripts/mod/modpost
  CHK     include/generated/compile.h
  CHK     kernel/config_data.h
  Kernel: arch/arm/boot/Image is ready
  Kernel: arch/arm/boot/zImage is ready
make[1]: Leaving directory '/home/mighty/Halium/kernel/samsung/espresso'
Building DTBs
make[1]: Entering directory '/home/mighty/Halium/kernel/samsung/espresso'
  CC      scripts/mod/devicetable-offsets.s
  GEN     scripts/mod/devicetable-offsets.h
  HOSTCC  scripts/mod/file2alias.o
  HOSTLD  scripts/mod/modpost
make[1]: Leaving directory '/home/mighty/Halium/kernel/samsung/espresso'
Building Kernel Modules
make[1]: Entering directory '/home/mighty/Halium/kernel/samsung/espresso'
  GEN     /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/Makefile
  CHK     include/generated/uapi/linux/version.h
  CC      scripts/mod/devicetable-offsets.s
  GEN     scripts/mod/devicetable-offsets.h
  Using /home/mighty/Halium/kernel/samsung/espresso as source for kernel
  HOSTCC  scripts/mod/file2alias.o
  CHK     include/generated/utsrelease.h
make[3]: 'include/generated/mach-types.h' is up to date.
  CALL    /home/mighty/Halium/kernel/samsung/espresso/scripts/checksyscalls.sh
  HOSTLD  scripts/mod/modpost
  Building modules, stage 2.
  MODPOST 0 modules
make[1]: Leaving directory '/home/mighty/Halium/kernel/samsung/espresso'
make ARCH=arm KERNELDIR=/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ OUT=/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km -C hardware/ti/omap4/pvr-source/eurasiacon/build/linux2/omap_android clean && make ARCH=arm KERNELDIR=/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ OUT=/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km -C hardware/ti/omap4/pvr-source/eurasiacon/build/linux2/omap_android CROSS_COMPILE="/usr/bin/ccache arm-linux-androidkernel-" \
	TARGET_DEVICE=blaze
make[1]: Entering directory '/home/mighty/Halium'
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
../common/android/platform_version.mk:63: *** No device prop file (/home/mighty/Halium/out/target/product/espresso3g/system/build.prop). Extracting from build/core/version_defaults.mk
PLATFORM_RELEASE=7.1.1 & PLATFORM_CODENAME=REL
WARNING: Android version is newer than this DDK supports
  RM       /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/host /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/docs
make[1]: Leaving directory '/home/mighty/Halium/hardware/ti/omap4/pvr-source/eurasiacon/build/linux2/omap_android'
make[1]: Entering directory '/home/mighty/Halium'
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
../common/android/platform_version.mk:63: *** No device prop file (/home/mighty/Halium/out/target/product/espresso3g/system/build.prop). Extracting from build/core/version_defaults.mk
PLATFORM_RELEASE=7.1.1 & PLATFORM_CODENAME=REL
WARNING: Android version is newer than this DDK supports
../config/core.mk:480: $(KERNELDIR)/vmlinux does not exist. Kbuild may fail.
make -C /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ \
KBUILD_SRC=/home/mighty/Halium/kernel/samsung/espresso \
KBUILD_EXTMOD="/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild" -f /home/mighty/Halium/kernel/samsung/espresso/Makefile \

  LD      /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/built-in.o
  CC [M]  /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/3rdparty/dc_omapfb3_linux/omaplfb_displayclass.o
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/3rdparty/dc_omapfb3_linux/omaplfb_displayclass.c:1300:22: warning: 'OMAPLFBInitFBVRAM' defined but not used [-Wunused-function]
 static OMAPLFB_ERROR OMAPLFBInitFBVRAM(OMAPLFB_DEVINFO *psDevInfo,
                      ^
  CC [M]  /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/3rdparty/dc_omapfb3_linux/omaplfb_linux.o
  CC [M]  /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/osfunc.o
  CC [M]  /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/mutils.o
  CC [M]  /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/mmap.o
  CC [M]  /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/module.o
  CC [M]  /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/pdump.o
  CC [M]  /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.o
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c: In function 'pvr_proc_open':
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:226:9: error: implicit declaration of function 'PDE' [-Werror=implicit-function-declaration]
  struct pvr_proc_dir_entry* ppde = PDE_DATA(inode);
         ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:138:30: error: invalid type argument of '->' (have 'int')
 #define PDE_DATA(x)    PDE(x)->data;
                              ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:226:36: note: in expansion of macro 'PDE_DATA'
  struct pvr_proc_dir_entry* ppde = PDE_DATA(inode);
                                    ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c: In function 'pvr_proc_write':
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:138:30: error: invalid type argument of '->' (have 'int')
 #define PDE_DATA(x)    PDE(x)->data;
                              ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:251:9: note: in expansion of macro 'PDE_DATA'
  ppde = PDE_DATA(inode);
         ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c: In function 'RemoveProcEntrySeq':
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:730:29: error: dereferencing pointer to incomplete type
  remove_proc_entry(ppde->pde->name, dir);
                             ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c: In function 'RemovePerProcessProcEntrySeq':
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:773:36: error: dereferencing pointer to incomplete type
         remove_proc_entry(ppde->pde->name, psPerProc->psProcDir);
                                    ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c: In function 'RemovePerProcessProcDir':
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:824:36: error: dereferencing pointer to incomplete type
         while (psPerProc->psProcDir->subdir)
                                    ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:828:49: error: dereferencing pointer to incomplete type
             RemoveProcEntry(psPerProc->psProcDir->subdir->name);
                                                 ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:830:45: error: dereferencing pointer to incomplete type
         RemoveProcEntry(psPerProc->psProcDir->name);
                                             ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c: In function 'RemoveProcEntries':
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:870:12: error: dereferencing pointer to incomplete type
  while (dir->subdir)
            ^
/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.c:874:22: error: dereferencing pointer to incomplete type
   RemoveProcEntry(dir->subdir->name);
                      ^
cc1: all warnings being treated as errors
make[6]: *** [/home/mighty/Halium/kernel/samsung/espresso/scripts/Makefile.build:309: /home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild/services4/srvkm/env/linux/proc.o] Error 1
make[5]: *** [/home/mighty/Halium/kernel/samsung/espresso/Makefile:1228: _module_/home/mighty/Halium/out/target/product/espresso3g/obj/KERNEL_OBJ/pvr-km/target/kbuild] Error 2
make[4]: *** [Makefile:130: sub-make] Error 2
make[3]: *** [Makefile:26: all] Error 2
make[2]: *** [eurasiacon/build/linux2/kbuild/kbuild.mk:56: kbuild] Error 2
make[1]: *** [../config/core.mk:711: build] Error 2
make[1]: Leaving directory '/home/mighty/Halium/hardware/ti/omap4/pvr-source/eurasiacon/build/linux2/omap_android'
make: *** [hardware/ti/omap4/pvr-km.mk:22: BUILD_PVR] Error 2
make: Leaving directory '/home/mighty/Halium'

#### make failed to build some targets (36 seconds) ####

@MightyM17
Copy link
Author

I hope someone can help me here, I wont be having much time for halium

@SakiiCode
Copy link

SakiiCode commented Jan 31, 2021

I tried copying Unlegacy-Android's CM12.1 manifest to halium, it worked at the beginning, then at some point gave FATAL: Kernel too old error (it's 3.0.x only).

Then replaced its kernel with TI's 3.10.y branch and got into the endless loop of fixing driver compilation errors. The android_hardware_ti_omap repo seems to be outdated for this purpose but don't know much about it

@MightyM17
Copy link
Author

Yes even i faced that problem the hardware_ti_omap is ancient

@MightyM17
Copy link
Author

Device boots into power reset mode maybe the kernel panics :(

@MightyM17
Copy link
Author

halium boot doesnt work at all, hybris boot atleast boots

@MightyM17
Copy link
Author

MightyM17 commented May 15, 2021

Update: It finally boots!! Using https://github.com/Unlegacy-Android/android_kernel_ti_omap4/tree/3.4/common/ with XZ compression the boot image finally fits for the tab, no more power reset mode. No display yet.
test_hwcomposer fails with Segmantation fault. Here are more logs

phablet@ubuntu-phablet:~$ sudo unity-system-compositor --debug-without-dm 
[2021-05-15 07:50:18.438629] <information> mirserver: Starting
[2021-05-15 07:50:18.461883] < - debug - > mirserver: Not using logind for session management: Seat has no active session
[2021-05-15 07:50:18.465393] < - debug - > mirserver: Using Linux VT subsystem for session management
[2021-05-15 07:50:18.469024] <information> mircommon: Loading modules from: /usr/lib/arm-linux-gnueabihf/mir/server-platform
[2021-05-15 07:50:18.470245] <information> mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/graphics-android.so.15
[2021-05-15 07:50:18.471160] <information> mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/graphics-android-caf.so.15
[2021-05-15 07:50:18.471832] <information> mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/input-evdev.so.7
[2021-05-15 07:50:18.486358] <information> mirplatform: Found graphics driver: mir:android (version 1.1.0) Support priority: 256
[2021-05-15 07:50:18.488250] <information> mirplatform: Found graphics driver: mir:android-caf (version 1.1.0) Support priority: 0
[2021-05-15 07:50:18.489990] <information> mirserver: Selected driver: mir:android (version 1.1.0)
library "libgui.so" wasn't loaded and RTLD_NOLOAD prevented it
library "libPVROGL.so" not found
library "libPVROCL.so" not found
failed to open gralloc module with both version 0 and 1 methods
unity-system-compositor: gralloc.c:125: hybris_gralloc_initialize: Assertion `NULL' failed.
Aborted

@RealTheHexagon
Copy link

Hey, I have a espressowifi. Can I help with the porting? Just send me your manifest

@RealTheHexagon
Copy link

Thanks. I'll start building, and let you know.

@MightyM17
Copy link
Author

Also you need to change the defconfig, add these to espresso_defconfig

CONFIG_KERNEL_GZIP=n
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_KERNEL_XZ=y

(Also do the normal ubports/halium changes)

@RealTheHexagon
Copy link

Wait, do I add the libcorkscrew back?

@MightyM17
Copy link
Author

Yes add it back

@MightyM17
Copy link
Author

Ubuntu touch boots and works with ui!

@RealTheHexagon
Copy link

RealTheHexagon commented Aug 3, 2021

dude how??? i thought that device hated ub touch

@MightyM17
Copy link
Author

Haha, it doesnt, I can upload the system.img and halium-boot.img and/or upload the sources I used to build :D

@RealTheHexagon
Copy link

Just update all your sources. I cant port rn, because I have exams coming up and I have to prepare.

@massimo1980
Copy link

massimo1980 commented Jan 3, 2023

I'll be more than happy if you'll give it a go
in this way i can finally understand what i'm doing wrong 🤣
I've also tried with another tablet ( espresso-wifi ....same model without modem ) but the result it's the same:

  • no wifi driver
  • same error on the ducati xen3 file
  • stuck at boot logo
  • oh...an various AppArmor errors ( for both devices ) that i forgot to mention ( resolved after install apparmor-utils )

@MightyM17
Copy link
Author

Give me a day or two, gotta download all sources and give it a go

@MightyM17
Copy link
Author

MightyM17 commented Jan 4, 2023

Well its stuck on the Ubuntu logo now
10 mins later it works

@massimo1980
Copy link

massimo1980 commented Jan 4, 2023

😨 so it works for you ?
well...i don't know...i've waited more then 1 hour watching that screen
can u please send me "dmseg" and "syslog" ? so i can compare it with mine
P.S.: halium-boot right ? not hybris
also everything well with wifi driver ?

@MightyM17
Copy link
Author

IMG_20230104_190537
Proof :D

@massimo1980
Copy link

IMG20230104144710

😭😭😭

@MightyM17
Copy link
Author

IMG20230104144710

😭😭😭

How long? Took quite a while (20 mins) for me

@massimo1980
Copy link

passed about 15 minutes....i'm constantly checking on syslog
but only this:

Jan  4 13:56:32 ubuntu-phablet wpa_supplicant[772]: rfkill: WLAN unblocked
Jan  4 13:56:35 ubuntu-phablet kernel: [  824.035369] hub 1-0:1.0: hub_suspend
Jan  4 13:56:35 ubuntu-phablet kernel: [  824.035430] usb usb1: bus auto-suspend, wakeup 1
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.441345] PM: suspend entry 2023-01-04 13:56:43.779445429 UTC
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.441375] PM: Syncing filesystems ... done.
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.442382] PM: Preparing system for mem sleep
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.442779] Freezing user space processes ... (elapsed 0.002 seconds) done.
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.445159] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.446807] PM: Entering mem sleep
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.446807] LDO3: No configuration
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.446838] LDO4: No configuration
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.447784] LDO1: No configuration
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.447814] LDO5: No configuration
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.447814] VANA: No configuration
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.448028] Suspending console(s) (use no_console_suspend to debug)
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.650024] usb usb1: usb auto-resume
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.667877] hub 1-0:1.0: hub_resume
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.667938] hub 1-0:1.0: hub_suspend
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.667968] usb usb1: bus suspend, wakeup 0
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.668457] dpm_run_callback(): platform_pm_suspend+0x0/0x64 returns -22
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.668457] PM: Device omap_hsmmc.4 failed to suspend: error -22
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.668487] PM: Some devices failed to suspend
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.668823] usb usb1: usb resume
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.691314] hub 1-0:1.0: hub_resume
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.692749] PM: resume of devices complete after 24.261 msecs
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.697418] PM: Finishing wakeup.
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.697448] Restarting tasks ...
Jan  4 13:56:44 ubuntu-phablet kernel: [  832.698028] hub 1-0:1.0: state 7 ports 1 chg 0000 evt 0000
Jan  4 13:56:44 ubuntu-phablet wpa_supplicant[772]: rfkill: WLAN unblocked
Jan  4 13:56:44 ubuntu-phablet wpa_supplicant[772]: rfkill: WLAN unblocked
Jan  4 13:56:46 ubuntu-phablet kernel: [  835.035675] hub 1-0:1.0: hub_suspend
Jan  4 13:56:46 ubuntu-phablet kernel: [  835.035827] usb usb1: bus auto-suspend, wakeup 1
Jan  4 13:56:46 ubuntu-phablet kernel: [  835.579193] PM: suspend entry 2023-01-04 13:56:46.917232294 UTC
Jan  4 13:56:46 ubuntu-phablet kernel: [  835.579223] PM: Syncing filesystems ... done.
Jan  4 13:56:46 ubuntu-phablet kernel: [  835.582122] PM: Preparing system for mem sleep
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.592590] Freezing user space processes ... (elapsed 0.001 seconds) done.
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.594543] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.595977] PM: Entering mem sleep
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.596008] LDO3: No configuration
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.596008] LDO4: No configuration
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.596954] LDO1: No configuration
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.596984] LDO5: No configuration
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.596984] VANA: No configuration
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.597198] Suspending console(s) (use no_console_suspend to debug)
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.799163] usb usb1: usb auto-resume
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.816314] hub 1-0:1.0: hub_resume
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.816375] hub 1-0:1.0: hub_suspend
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.816406] usb usb1: bus suspend, wakeup 0
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.816833] dpm_run_callback(): platform_pm_suspend+0x0/0x64 returns -22
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.816833] PM: Device omap_hsmmc.4 failed to suspend: error -22
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.816864] PM: Some devices failed to suspend
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.817169] usb usb1: usb resume
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.839752] hub 1-0:1.0: hub_resume
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.841156] PM: resume of devices complete after 24.291 msecs
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.845794] PM: Finishing wakeup.
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.845794] Restarting tasks ...
Jan  4 13:56:47 ubuntu-phablet kernel: [  835.846435] hub 1-0:1.0: state 7 ports 1 chg 0000 evt 0000
Jan  4 13:56:47 ubuntu-phablet wpa_supplicant[772]: rfkill: WLAN unblocked
Jan  4 13:56:47 ubuntu-phablet wpa_supplicant[772]: rfkill: WLAN unblocked

@MightyM17
Copy link
Author

MightyM17 commented Jan 4, 2023

Did you set up udev rules? https://docs.halium.org/en/latest/porting/debug-build/udev.html
On another note bcmdhd module is missing in my build where is it for you?

@massimo1980
Copy link

yep...
followed that guide for both udev rules and wifi driver issue

@MightyM17
Copy link
Author

yep... followed that guide for both udev rules and wifi driver issue

Where is bcmdhd.ko in your device?

@massimo1980
Copy link

that file wasn't inside the image builded. I had to manually copy into /lib/modules/

@massimo1980
Copy link

massimo1980 commented Jan 4, 2023

I can't believe It .. After redoing the udev rules It works!!
Mighty you are really awesome man!! Thanks again!!!
1672841497441692566629764005763

@MightyM17
Copy link
Author

that file wasn't inside the image builded. I had to manually copy into /lib/modules/

Weird why it didnt exist? You got it from out?

@MightyM17
Copy link
Author

Congrats it works!!!

@massimo1980
Copy link

that file wasn't inside the image builded. I had to manually copy into /lib/modules/

Weird why it didnt exist? You got it from out?

yep...from:
./out/target/product/espresso3g/obj/KERNEL_OBJ/drivers/net/wireless/bcmdhd/bcmdhd.ko

cause i searched in every partitions and img file ...but not found
so in the end i copied manually and modified the .rc script to load the driver

@MightyM17
Copy link
Author

Ah nice, next thing to fix would be bluetooth ig?

@massimo1980
Copy link

massimo1980 commented Jan 4, 2023

Ah nice, next thing to fix would be bluetooth ig?

i'm watching right now...but seems a little bit strange

phablet@ubuntu-phablet:~$ dmesg | grep -i blue
[    0.379943] Bluetooth: Core ver 2.16
[    0.380096] Bluetooth: HCI device and connection manager initialized
[    0.380126] Bluetooth: HCI socket layer initialized
[    0.380157] Bluetooth: L2CAP socket layer initialized
[    0.380218] Bluetooth: SCO socket layer initialized
[    2.337036] Bluetooth: RFCOMM TTY layer initialized
[    2.337310] Bluetooth: RFCOMM socket layer initialized
[    2.337463] Bluetooth: RFCOMM ver 1.11
[    2.337585] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[    2.337738] Bluetooth: BNEP filters: protocol multicast
[    2.337890] Bluetooth: HIDP (Human Interface Emulation) ver 1.2
[   20.540832] [BT] Bluetooth Power On.
phablet@ubuntu-phablet:~$
phablet@ubuntu-phablet:~$ sudo rfkill list
0: bcm4330 Bluetooth: Bluetooth
        Soft blocked: no
        Hard blocked: no
1: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: no
2: brcmfmac-wifi: Wireless LAN
        Soft blocked: no
        Hard blocked: no
phablet@ubuntu-phablet:~$
phablet@ubuntu-phablet:~$ hcitool dev
Devices:
phablet@ubuntu-phablet:~$

@MightyM17
Copy link
Author

No clues, maybe the wiki has some ideas?

@massimo1980
Copy link

massimo1980 commented Jan 4, 2023

No clues, maybe the wiki has some ideas?

actually there's no module loaded for bluetooth :) that's for sure a start point
https://docs.ubports.com/en/latest/porting/configure_test_fix/Bluetooth.html

@MightyM17
Copy link
Author

No clues, maybe the wiki has some ideas?

actually there's no module loaded for bluetooth :) that's for sure a start point

Ugh half the modules are just not loaded :/

@massimo1980
Copy link

No clues, maybe the wiki has some ideas?

actually there's no module loaded for bluetooth :) that's for sure a start point

Ugh half the modules are just not loaded :/

maybe i've just said a BS ....seems that the chip is the same as the wifi
in fact in the syslog seems to be loaded correctly

phablet@ubuntu-phablet:~$ sudo cat /var/log/syslog | grep -i tooth
Jan  3 20:50:35 ubuntu-phablet kernel: [    1.105743] Bluetooth: Core ver 2.16
Jan  3 20:50:35 ubuntu-phablet kernel: [    1.105895] Bluetooth: HCI device and connection manager initialized
Jan  3 20:50:35 ubuntu-phablet kernel: [    1.105926] Bluetooth: HCI socket layer initialized
Jan  3 20:50:35 ubuntu-phablet kernel: [    1.105957] Bluetooth: L2CAP socket layer initialized
Jan  3 20:50:35 ubuntu-phablet kernel: [    1.106018] Bluetooth: SCO socket layer initialized
Jan  3 20:50:35 ubuntu-phablet kernel: [    3.053131] Bluetooth: RFCOMM TTY layer initialized
Jan  3 20:50:35 ubuntu-phablet kernel: [    3.053314] Bluetooth: RFCOMM socket layer initialized
Jan  3 20:50:35 ubuntu-phablet kernel: [    3.053558] Bluetooth: RFCOMM ver 1.11
Jan  3 20:50:35 ubuntu-phablet kernel: [    3.053710] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
Jan  3 20:50:35 ubuntu-phablet kernel: [    3.053955] Bluetooth: BNEP filters: protocol multicast
Jan  3 20:50:35 ubuntu-phablet kernel: [    3.054107] Bluetooth: HIDP (Human Interface Emulation) ver 1.2
Jan  3 20:50:36 ubuntu-phablet bluetoothd[848]: Bluetooth daemon 5.41
Jan  3 20:50:36 ubuntu-phablet bluetoothd[848]: Starting SDP server
Jan  3 20:50:36 ubuntu-phablet bluetoothd[848]: Bluetooth management interface 1.0 initialized
Jan  3 20:50:42 ubuntu-phablet NetworkManager[1183]: <info>  [1672779042.2824] Loaded device plugin: NMBluezManager (/usr/lib/arm-linux-gnueabihf/NetworkManager/libnm-device-plugin-bluetooth.so)
Jan  3 20:50:42 ubuntu-phablet URfkill[776]: Setting device 0 (BLUETOOTH) to unblocked
Jan  3 20:50:42 ubuntu-phablet URfkill[776]: set_soft: Setting BLUETOOTH to unblocked
Jan  3 20:50:42 ubuntu-phablet kernel: [   21.501281] [BT] Bluetooth Power On.
Jan  3 20:50:42 ubuntu-phablet URfkill[776]: device_changed_cb: bcm4330 Bluetooth

@MightyM17
Copy link
Author

Have a look at the wiki i linked above, maybe that'll make it work

@massimo1980
Copy link

massimo1980 commented Jan 5, 2023

I searched in the Halium's docs but only this one:
https://docs.halium.org/en/latest/porting/common-system-build-errors.html?highlight=bluetooth#undefined-or-missing-bluetooth-headers
don't think that it's our case cause as i said, seems that the bt module is loaded at boot
following this one, instead:
https://docs.ubports.com/en/latest/porting/configure_test_fix/Bluetooth.html
says that there's this file
/etc/init/bluetooth-touch-android.conf
where you can configure adaptations for you bt thourgh HCI tools, this is an example for Nexus 6P
https://github.com/Flohack74/android_device_huawei_angler/blob/halium-7.1/ubuntu/bluetooth/bluetooth-touch-android.conf
i've found this old one from a repo:
https://github.com/yacuken/droid-config-espresso3g/blob/master/sparse/lib/systemd/system/hciattach.service

Following this one, i've tried to adapt the command to my device:

root@ubuntu-phablet:~# /usr/bin/hciattach -f /android/vendor/firmware ttyO1 bcm43xx 4000000 noflow sleep /android/efs/bluetooth/bt_addr
bcm43xx_init
Patch not found, continue anyway
Set BDADDR UART: /android/efs/bluetooth/bt_addr
Incorrect bdaddr
Set Controller clock (1)
Set Controller UART speed to 4000000 bit/s
Can't set line discipline: Invalid argument
Can't initialize device: Invalid argument
root@ubuntu-phablet:~#
root@ubuntu-phablet:~# /usr/bin/hciattach -f /android/vendor/firmware ttyO0 bcm43xx 4000000 noflow sleep /android/efs/bluetooth/bt_addr
bcm43xx_init
Initialization timed out.

with no luck...

EDIT:
even "bluetoothhctl" seems not working:

root@ubuntu-phablet:~# /usr/bin/bluetoothctl power off
[bluetooth]# nnect to bluetoothd...

and get stuck there...

@MightyM17
Copy link
Author

What does dmesg say?
The old repo looks like SailfishOS lol

@massimo1980
Copy link

What does dmesg say?
The old repo looks like SailfishOS lol

phablet@ubuntu-phablet:~$ dmesg | grep -i blue
[ 0.379943] Bluetooth: Core ver 2.16
[ 0.380096] Bluetooth: HCI device and connection manager initialized
[ 0.380126] Bluetooth: HCI socket layer initialized
[ 0.380157] Bluetooth: L2CAP socket layer initialized
[ 0.380218] Bluetooth: SCO socket layer initialized
[ 2.337036] Bluetooth: RFCOMM TTY layer initialized
[ 2.337310] Bluetooth: RFCOMM socket layer initialized
[ 2.337463] Bluetooth: RFCOMM ver 1.11
[ 2.337585] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[ 2.337738] Bluetooth: BNEP filters: protocol multicast
[ 2.337890] Bluetooth: HIDP (Human Interface Emulation) ver 1.2
[ 20.540832] [BT] Bluetooth Power On.

@MightyM17
Copy link
Author

What does dmesg say?
The old repo looks like SailfishOS lol

phablet@ubuntu-phablet:~$ dmesg | grep -i blue [ 0.379943] Bluetooth: Core ver 2.16 [ 0.380096] Bluetooth: HCI device and connection manager initialized [ 0.380126] Bluetooth: HCI socket layer initialized [ 0.380157] Bluetooth: L2CAP socket layer initialized [ 0.380218] Bluetooth: SCO socket layer initialized [ 2.337036] Bluetooth: RFCOMM TTY layer initialized [ 2.337310] Bluetooth: RFCOMM socket layer initialized [ 2.337463] Bluetooth: RFCOMM ver 1.11 [ 2.337585] Bluetooth: BNEP (Ethernet Emulation) ver 1.3 [ 2.337738] Bluetooth: BNEP filters: protocol multicast [ 2.337890] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 [ 20.540832] [BT] Bluetooth Power On.

Everything seems fine here, sorry wont be working a lot on halium as Oreo is the focus now :D
But, as the guide suggests you'll have to do some backporting of drivers to our 3.4 kernel. The BCM4430 chipset used is quite common so you should be able to get similar devices in halium and look at how they made bluetooth work

@acewayx
Copy link

acewayx commented Oct 6, 2024

so uhm can anyone please share the complete files or smth ?
Cuz i would love to install this on my p5110

@MightyM17
Copy link
Author

so uhm can anyone please share the complete files or smth ? Cuz i would love to install this on my p5110

Wdym by complete files? Well sources are on my github, and mentioned here or on xda :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants