-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volumes < 1 #12
Comments
This is a required feature, this should be possible to disable update where numbers are 0, to avoid a HTRUC failure. As for the dataset, @alix-tz I think we should allow that, but maybe add a new feature such as dataset type ? (not for right now) |
thanks @PonteIneptique for the quick reply 🙏 So for now we live with it, alles klar! I'll make a PR in any case to add our dataset to the HTR-united catalog asap. Out of curiosity: is this a validity constraint that can (should?) be relaxed in the JSON schema? |
That's a good question. I strongly believe we should not allow 0-valued quantities, but I can see an argument for it. It'll depend on @alix-tz feedback. |
Ok, I definitely agree that we should allow HTRUC to pass in such cases, alles klar for me too! |
I hotfixed the schema accordingly, can you check if it works @mromanello |
Thanks @PonteIneptique I've just re-run the GH actions, and the red flag is gone! I'll make soon a PR for adding the dataset to the HTR-united catalog. (This issue can be closed for me). |
I released it as a hotfix, as it should not break anything. |
Hi guys 👋
First off, big kudos to you both for this neat suite of tools to work with HTR-united's data.
I'm preparing a dataset that contains page region annotations (Zones) but not OCR groundtruth.
The dataset passes the
HTRVX
andHTR_United_Metadata_Generator
validation without issues, but it fails withHTRUC
becausevolume < 1
in characters and lines (because of missing OCR).My assumption was that it would be possible to add to HTR-united's catalog a dataset containing OLR but not OCR GT data... but perhaps this is not true? 🤔
Any help is appreciated 🙏 cheers!
The text was updated successfully, but these errors were encountered: