Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report (Submitted by 3723) - Sorting by team name when viewing IIHF cards is innacurate #226

Open
GuthrieW opened this issue Nov 2, 2024 · 4 comments
Assignees
Labels
bug A problem to be fix in the application

Comments

@GuthrieW
Copy link
Owner

GuthrieW commented Nov 2, 2024

Description

Sorting my own collection from A-Z. With IIHF it doesn't work because country names don't appear in alphabetical order but in a seemingly random order, see 2 examples here https://imgur.com/a/P80Vt3Q
For SHL teams sorting works, sorted A-Z > Atlanta comes first and Winnipeg last.

Reproduction Steps

Went to my own collection, filtered by IIHF awards cards and then selected A-Z (also activated cards I don't own).

Operating System

Windows

Browser

Chrome

Device

Desktop

@GuthrieW GuthrieW added the bug A problem to be fix in the application label Nov 2, 2024
@GuthrieW GuthrieW self-assigned this Nov 2, 2024
@luketd
Copy link
Collaborator

luketd commented Nov 2, 2024

Is due to the team_data only having SHL names. Not confident enough of SQL and kinda low pri to put the time into dealing with the logic

@GuthrieW
Copy link
Owner Author

We should be able to fix this by checking if rarities includes "IIHF", if true then add this to the WHERE clause (team.LeagueID=2).

@luketd
Copy link
Collaborator

luketd commented Nov 28, 2024

yeah that makes sense. I can take a look at that this weekend

@GuthrieW GuthrieW changed the title Bug Report (Submitted by 3723) Bug Report (Submitted by 3723) - Sorting by team name when viewing IIHF cards is innacurate Dec 29, 2024
@GuthrieW
Copy link
Owner Author

Option 1: Remove sorting by team name when viewing IIHF cards
Option 2: Actually implement this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem to be fix in the application
Projects
None yet
Development

No branches or pull requests

2 participants