Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

목표 삭제 기능 적용 #108

Open
3 tasks done
junu0516 opened this issue Nov 19, 2022 · 1 comment · May be fixed by #111
Open
3 tasks done

목표 삭제 기능 적용 #108

junu0516 opened this issue Nov 19, 2022 · 1 comment · May be fixed by #111
Assignees
@junu0516
Labels
feat 새로운 기능에 대한 이슈 jed jed 진행

Comments

@junu0516
Copy link
Collaborator

junu0516 commented Nov 19, 2022 •
edited
Loading

  • 삭제처리할 UI 요소 추가
  • Realm에 접근 후 삭제
  • 삭제 재확인
@junu0516 junu0516 added feat 새로운 기능에 대한 이슈 jed jed 진행 labels Nov 19, 2022
@junu0516 junu0516 self-assigned this Nov 19, 2022
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
refactor: [#108] viewModel에 값 전달하는 부분 위치 변경
0cb42fe 
다시보니 굳이 viewWillAppear(_:)에 있을 필요가 없음
@junu0516
Copy link
Collaborator Author

  • 우측 상단에 추가 메뉴 띄우는 버튼
  • 오른쪽 -> 왼쪽 방향으로 swipe action 취했을 때 부가 버튼 보여주기

junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
feat: [#108] 목표 셀 우측 상단에 메뉴버튼 추가
3fda76b 
- swipe의 경우 테이블 뷰에 비해 컬렉션 뷰는 iOS14 이후로 Compositional Layout 내부에 적용할 수 있기 때문에 우선은 메뉴버튼으로 대체
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
feat: [#108] 목표 셀의 메뉴버튼 터치했을 때 GoalListViewModel로 이벤트 전달
141a4c8
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
refactor: [#108] GoalListCollectionViewCell 내부의 configure(goal:)을 내부함…
2a28b91 
…수 추가해서 좀 더 의미 분명하게 수정
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
feat: [#108] 목표 셀의 메뉴버튼 터치했을 때, 하단에 액션 시트 보여주는 기능 추가
0517c99
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
feat: [#108] RealmManager에 삭제 메소드 추가
cbb91b2
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
feat: [#108] GoalListRepository에 목표 삭제 요청 메소드 추가
a325edf
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
feat: [#108] GoalListViewModel의 deleteGoal 속성에 GoalListRepository의 목표…
12190cb 
… 삭제하는 메소드 바인딩
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
feat: [#108] 목표 삭제 후 alert 보여주도록 처리
79f41c4
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
feat: [#108] 목표 삭제 시 재확인 메시지 보여주는 기능 추가
5687268
junu0516 added a commit that referenced this issue Nov 26, 2022
@junu0516
chore: [#108] 불필요한 코드 정리
b744859
@junu0516 junu0516 linked a pull request Nov 27, 2022 that will close this issue
Open
@junu0516 junu0516 linked a pull request Nov 27, 2022 that will close this issue
목표 삭제 기능 구현 #111
Open
junu0516 added a commit that referenced this issue Dec 4, 2022
@junu0516
chore: [#108] menuButton.rx.tap 으로 변경
907f588
junu0516 added a commit that referenced this issue Dec 4, 2022
@junu0516
chore: [#108] configure의 내부 함수롤 외부의 private 함수로 변경
a9eea1b
junu0516 added a commit that referenced this issue Dec 4, 2022
@junu0516
chore: [#108] deleteGoal 메소드 파라미터에 와일드카드 적용
2d1645d
junu0516 added a commit that referenced this issue Dec 6, 2022
@junu0516
refactor: [#108] 목표 삭제 관련 바인딩 2단계로 분기
10585f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junu0516 junu0516

Labels
feat 새로운 기능에 대한 이슈 jed jed 진행
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat/GoalRemoval GunZaStation/Rabit
목표 삭제 기능 구현 GunZaStation/Rabit
1 participant
@junu0516