Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to configure with plug.kak; make posix-compliant #1

Open
kanashimia opened this issue Jul 3, 2020 · 2 comments
Open

How to configure with plug.kak; make posix-compliant #1

kanashimia opened this issue Jul 3, 2020 · 2 comments

Comments

@kanashimia
Copy link

"You can config coqoune within plug.kak as well" so, may i ask, how? Example code, doesn't do it.
Especially cant figure how to set coqoune_path,
tried adding [..] config %{ set-option global coqoune_path "%opt{plug_install_dir}/coqoune" } - it just ignores it ¯\_(ツ)_/¯

Also scripts aren't posix-compliant, and don't work when you use dash (nor even work with zsh - one has to use bash)
Just changing #!/bin/sh to #!/bin/bash isn't enough - you have to at least fix %sh{ .. } expands

@Guest0x0
Copy link
Owner

Guest0x0 commented Jul 4, 2020

In terms of the coqoune_path option, The code setting it is

declare-option str coqoune_path %sh{
    echo ${kak_source:0:-15}
}

which should set the option correctly on script loading ...
I am not familiar with plug.kak internals, so could you please post your config concerning coqoune and plug.kak?

As for the POSIX issue, I should have avoided bashism like process substitution.
But yes, on my system sh is linked to bash.
I am not quite familiar with the minor differences between shells,
so could you please post the error shown when executing the scripts using another shell?

Oh I just found how little I know about shells...
Yes, the scripts are not POSIX.
As they use arrays heavily, I am not confident in making them so.
So sorry for the wrong statement in README,
I'll fix the document, and try to support bash, zsh and ksh, perhaps through a configurable option.

Finally, thanks for your good first issue!

@Guest0x0
Copy link
Owner

Guest0x0 commented Jul 5, 2020

Now coqoune can run with any of zsh, bash and ksh, neither needs to be the default shell.

However, I failed to reproduce the plug.kak issue on another system.
Perhaps you forgot to call coq-start manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants