Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Coveralls into Perceval #1

Open
4 tasks
vchrombie opened this issue Jan 23, 2022 · 0 comments
Open
4 tasks

Integrating Coveralls into Perceval #1

vchrombie opened this issue Jan 23, 2022 · 0 comments

Comments

@vchrombie
Copy link

vchrombie commented Jan 23, 2022

Hi @merijnS @wmeijer221

First of all, thank you for working on the Coveralls backend for Perceval. We really love to see new data sources being integrated with GrimoireLab.

I'm opening this issue as I found some potential improvements in the overall repo. These are just some of my comments, please feel free to decide for yourself. I have previously worked on creating perceval-zulip. So you can find all the references from that repo.

  • Perceval is fully supported by Poetry. So, you can avoid maintaining all the extra files. You can check the pyproject.toml to see how everything is configured.
  • If you are moving to Poetry, you can also update the instructions to install section.
  • Please add an example of how to use this tool. I think it needs a few arguments, at least the repo parameter ($ perceval coveralls github/chaoss/grimorielab-perceval), so you can add it to the documentation of how to use it.
  • We are using github action workflows for various things like ci tests, changelog checks, and also release automation (which builds, tests, and publishes your package to PyPI). You can make use of them if you feel they are helpful.

Feel free to ask if you need any help. I can open/review PRs if you want me to, please let me know. 🙂
You can close this issue whenever you want.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant