Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus metrics endpoint with proper tag support #9914

Closed
kroepke opened this issue Jan 15, 2021 · 4 comments · Fixed by #10767
Closed

Add prometheus metrics endpoint with proper tag support #9914

kroepke opened this issue Jan 15, 2021 · 4 comments · Fixed by #10767
Assignees
Milestone

Comments

@kroepke
Copy link
Member

kroepke commented Jan 15, 2021

What?

Add a Prometheus metrics endpoint to the standard of Graylog.
The exposed metrics should support tags for time series wherever they make sense, to more cleanly map to what Prometheus users expect to see.
It should be possible to bind the metrics endpoint to a separate address/port than the API, to allow for unauthenticated scraping from exporters/Prometheus. Oftentimes this will be either an internal monitoring network or localhost.

Why?

Exposing metrics in a flat way makes it difficult to work with using Prometheus and it is easier to flatten them for systems that do not have tag support, than the other way around.
Prometheus is a very common choice for collecting metrics, and Graylog should support it out of the box, without having to install an extra plugin that only solves half the problem.

Related issues:

graylog-labs/graylog-plugin-metrics-reporter#29
graylog-labs/graylog-plugin-metrics-reporter#35
graylog-labs/graylog-plugin-metrics-reporter#28

Your Environment

  • Elasticsearch Version: 4.0
@kroepke kroepke added this to the 4.1.0 milestone Jan 15, 2021
@mpfz0r
Copy link
Contributor

mpfz0r commented Jan 15, 2021

It might make sense to consider using https://micrometer.io/ instead of coding this directly for prometheus

@jalogisch
Copy link
Contributor

[z#844502]

@kroepke
Copy link
Member Author

kroepke commented Jan 15, 2021

We should definitely consider various options, yes!

@l0calhost
Copy link

l0calhost commented Jan 18, 2021

+1 for micrometer consideration, metric push mechanism would be a second big benefit to the tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants