Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack Plugin - Code Refactoring #611

Open
lingpri opened this issue Oct 26, 2020 · 1 comment
Open

Slack Plugin - Code Refactoring #611

lingpri opened this issue Oct 26, 2020 · 1 comment
Labels
improvement needs-discussion

Comments

@lingpri
Copy link
Contributor

lingpri commented Oct 26, 2020 •
edited
Loading

  1. execute method remove the call for validate method.
  2. Slack client needs its own SlackClientException similar to PagerDutyClientException.
  3. Update junit tests accordingly.
  4. update severity of notifications, Urgent vs Normal

Reference
Config validation happens when a user creates/modifies a Notification from the UI. It should not be possible for invalid config to exist at this point in processing.

Originally posted by @waab76 in #595 (comment)
@lingpri lingpri mentioned this issue Oct 26, 2020
Merged
@lingpri
Copy link
Contributor Author

lingpri commented Oct 26, 2020

#610

@lingpri lingpri changed the title Config validation happens when a user creates/modifies a Notification from the UI. It should not be possible for invalid config to exist at this point in processing. Slack Plugin - Code Refactoring Nov 4, 2020
@lingpri lingpri linked a pull request Nov 4, 2020 that will close this issue
Slack Plugin - server side exception handling for invalid webhook url #634
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement needs-discussion
Projects
None yet
Milestone
No milestone
1 participant
@lingpri