Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go version used in the published container #9642

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

plumpy
Copy link
Collaborator

@plumpy plumpy commented Jan 8, 2025

Right now the postsubmit build is failing:

7.258 go: github.com/jedisct1/go-minisign in vendor/modules.txt requires go >= 1.23.4 (running go 1.23.3)

@plumpy plumpy requested a review from Darien-Lin January 8, 2025 21:09
@plumpy plumpy requested a review from a team as a code owner January 8, 2025 21:09
Copy link

Gemini encountered an error creating the summary. You can try again by commenting @code-review-assist summarize.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, authored by plumpy, addresses a failing post-submit build caused by an incompatibility between the Go version used in the published container (1.23.3) and a dependency (github.com/jedisct1/go-minisign) requiring Go 1.23.4 or higher.

Intent: To fix the failing post-submit build by updating the Go version used in the published container image.

Changes:

  • The primary change is in the deploy/skaffold/Dockerfile.deps file. The Go version specified in the COPY instruction has been updated from golang:1.23.3 to golang:1.23.4.

Specifically, lines 166 and 167 of deploy/skaffold/Dockerfile.deps were modified:

Line Number Before Change After Change
166 COPY --from=golang:1.23.3 /usr/local/go /usr/local/go COPY --from=golang:1.23.4 /usr/local/go /usr/local/go

This ensures that the container uses a compatible Go version to resolve the dependency issue.

Activity: The pull request description clearly states the problem and its solution. No other activity is currently visible.


A little haiku to brighten your day:

Go version's update,
Fixes build, smooths the workflow,
Code now compiles.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change updates the Go version used in the Dockerfile to 1.23.4, which seems to be the correct fix for the build issue mentioned in the PR description. The change is small and targeted.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help everyone get up to speed:

This pull request, authored by plumpy, addresses a post-submit build failure caused by an incompatibility between the go-minisign library and the Go version used in the published Skaffold container. The specific error message indicated a need for Go version 1.23.4 or higher, while the existing build used 1.23.3.

Intent: To resolve the post-submit build failure by upgrading the Go version used in the Skaffold container image.

Changes:

The primary change is in the deploy/skaffold/Dockerfile.deps file. Specifically, line 166 was modified to update the base Go image used for building the Skaffold container from golang:1.23.3 to golang:1.23.4.

  • File Changed: deploy/skaffold/Dockerfile.deps
  • Line Changed: 166
  • Change: Updated the COPY instruction to use golang:1.23.4 instead of golang:1.23.3.

This simple change ensures the container uses a compatible Go version, resolving the build failure.

Here's a little haiku to brighten your day:

Go version's upgrade,
Fixes the build, smooth and swift,
Code now compiles!

Thanks,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change updates the Go version used in the Dockerfile. This fixes the build failure and is a necessary change.

@plumpy plumpy merged commit e6587b8 into GoogleContainerTools:main Jan 8, 2025
13 of 14 checks passed
@plumpy plumpy deleted the upgrade_go branch January 8, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants