Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused taggers field #9513

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Aug 29, 2024

Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

remove no-used taggers field

Copy link
Collaborator

@plumpy plumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I was wondering why this wasn't a problem before, and it looks like it's because the taggers field is never actually used. Can you just delete it instead?

Thanks for the PR!

Copy link

conventional-commit-lint-gcf bot commented Nov 9, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@cuishuang
Copy link
Contributor Author

Interesting, I was wondering why this wasn't a problem before, and it looks like it's because the taggers field is never actually used. Can you just delete it instead?

Thanks for the PR!

Of course. Please review again.

@cuishuang cuishuang changed the title bug: fix slice init length remove no-used taggers field Nov 9, 2024
@cuishuang cuishuang changed the title remove no-used taggers field refactor: remove no-used taggers field Nov 11, 2024
@plumpy plumpy changed the title refactor: remove no-used taggers field chore: remove unused taggers field Nov 11, 2024
@plumpy plumpy merged commit 264e274 into GoogleContainerTools:main Nov 11, 2024
10 of 11 checks passed
@plumpy
Copy link
Collaborator

plumpy commented Nov 11, 2024

Thanks for sending the PR, we appreciate it!

@cuishuang
Copy link
Contributor Author

Thanks for sending the PR, we appreciate it!

I am very happy to do this.

plumpy added a commit to plumpy/skaffold that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants