Cannot install via go install

[bagnaram]

Expected behavior

I expect to be able to install this program using go install github.com/GoogleContainerTools/skaffold/[email protected] or any version

Actual behavior

Go fails to fetch the package from the module because it is not found within a v2 directory. Everything is in a flat filesystem.

go: github.com/GoogleContainerTools/skaffold/[email protected]: module github.com/GoogleContainerTools/skaffold/[email protected] found, but does not contain package github.com/GoogleContainerTools/skaffold/v2

I expect them to be following the pattern in https://go.dev/blog/v2-go-modules

Information

• Skaffold version: v2.10.1
• Operating system: Linux fedora 6.7.5-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Feb 17 17:20:08 UTC 2024 x86_64 GNU/Linux
• Installed via: go install
• Contents of skaffold.yaml: N/A

Steps to reproduce the behavior

1. go install github.com/GoogleContainerTools/skaffold/[email protected]

[nathanperkins]

I believe the command you've given is incorrect but the correct one also fails:

[hi on] nathanperkins@nathanperkins:~$ go install github.com/GoogleContainerTools/skaffold/v2/cmd/skaffold@latest
go: github.com/GoogleContainerTools/skaffold/v2/cmd/skaffold@latest (in github.com/GoogleContainerTools/skaffold/[email protected]):
        The go.mod file for the module providing named packages contains one or
        more exclude directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.

It seems like these exclude directives are preventing go install and go run from working correctly:

// these require code change may remove these later
exclude (
	github.com/opencontainers/image-spec v1.1.0-rc3
	github.com/opencontainers/image-spec v1.1.0-rc4
)

// Unit tests fail due to a breaking change in reference.Parse() from this version.
exclude github.com/docker/distribution v2.8.3+incompatible

// this version requires code change may remove these later
exclude go.opentelemetry.io/otel/metric v0.37.0

// doesn't work well with windows
exclude github.com/karrick/godirwalk v1.17.0

According to golang/go#44840 (comment) (comment by @rsc), directives like replace (and exclude probably) prevent go install from working correctly. Healthy go versioning ecosystem should not use them.

[nathanperkins]

For anybody who needs a quick workaround to install:

SKAFFOLD_TAG=v2.13.2
cd "$(mktemp -d)"
git clone [email protected]:GoogleContainerTools/skaffold.git --depth=1 --branch="$SKAFFOLD_TAG" .
go install ./cmd/skaffold