feat: implement kaniko.imagePullSecret for pulling images from private registry w/ auth #9191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dherges
changed the title
dherges
force-pushed
the
feat/kaniko-imagepullsecret-impl
branch
from
df04663 to
2f3433f
Compare
|
Hello @aaron-prindle I rebased to latest main branch. Could you take a look? |
|
I think that would be a good update! |
|
@dherges |
alphanota
requested changes
Dec 17, 2024
| @@ -90,6 +90,13 @@ func (b *Builder) kanikoPodSpec(artifact *latest.KanikoArtifact, tag string, pla | |||
| addSecretVolume(pod, kaniko.DefaultSecretName, b.ClusterDetails.PullSecretMountPath, b.ClusterDetails.PullSecretName) | |||
| } | |||
|
|
|||
| // Add secret for pulling kaniko images from a private registry | |||
There was a problem hiding this comment.
Please add a test for this change in pod_test.go
dherges
force-pushed
the
feat/kaniko-imagepullsecret-impl
branch
from
2f3433f to
27288b8
Compare
conflicts resolved! |
dherges
force-pushed
the
feat/kaniko-imagepullsecret-impl
branch
from
a23dff9 to
ad28434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9170
Related: #9183 (closed), #9190
Merge before/after: after #9190
Description
Implements the config option, see #9183 and #9170
User facing changes (remove if N/A)
n/a
Follow-up Work (remove if N/A)
n/a