Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Verify] New config option to check images in local host before pull #9148

Closed
renzodavid9 opened this issue Oct 23, 2023 · 1 comment · Fixed by #9150
Closed

[Verify] New config option to check images in local host before pull #9148

renzodavid9 opened this issue Oct 23, 2023 · 1 comment · Fixed by #9150
Assignees
Labels
area/verify Issues related to skaffold verify command kind/feature-request
Milestone

Comments

@renzodavid9
Copy link
Contributor

Actual behavior

(Similar to #9139)
Right now, when we run a local verify test case, Skaffold will trigger a pull of the image every single time, e.g:

With this skaffold.yaml

apiVersion: skaffold/v4beta7
kind: Config

verify:
  - name: my-action
    container:
      name: gcloud-task
      image: gcr.io/cloud-builders/gcloud:latest
      command: ["/bin/sh"]
      args: ["-c", "gcloud version"]

Executing skaffold verify will produce the following logs:

latest: Pulling from cloud-builders/gcloud
Digest: sha256:0d6d21ed135170e723e982ce3a74b40255323dab446af149f51d73792a46d4eb
Status: Image is up to date for gcr.io/cloud-builders/gcloud:latest
...

The previous log indicates that Skaffold is triggering a pull of the gcloud image, even when the image is already in the local host.

Expected behavior

Same as described in #9139

@mepi262
Copy link

mepi262 commented Nov 8, 2024

@renzodavid9
The skaffold v2.9.0 has already been released, so it might be a good idea to close or delete the milestone v2.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/verify Issues related to skaffold verify command kind/feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants