Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useHelmSecrets not decrypting on render #7651

Closed
panbanda opened this issue Jul 15, 2022 · 5 comments · Fixed by #9295
Closed

useHelmSecrets not decrypting on render #7651

panbanda opened this issue Jul 15, 2022 · 5 comments · Fixed by #9295
Labels
area/render deploy/helm kind/bug Something isn't working priority/p2 May take a couple of releases

Comments

@panbanda
Copy link

Expected behavior

skaffold render should produce the same output as skaffold up for secrets that are used with useHelmSecrets: true

Actual behavior

skaffold render does not decrypt the secret, skaffold up does decrypt the secret

Information

Demo repo here:

https://github.com/panbanda/skaffold-helm-secrets-issue

Steps to reproduce the behavior

# Install SOPS sample gpg key
gpg --import pgp/sops_test_key.asc

# Encrypted with 
sops -e -i secrets.yaml

# Decrypted with 
sops -d -i secrets.yaml

# Skaffold dev puts the secret in container decrypted
# ie: test
skaffold dev

# Skaffold render creates a kube secret manifest with encrypted string
# ie: ENC[AES256_GCM,data:SyyH6w==,iv:CbNC...
skaffold render
@aaron-prindle aaron-prindle added deploy/helm kind/bug Something isn't working area/render priority/p2 May take a couple of releases labels Jul 17, 2022
@tejal29
Copy link
Contributor

tejal29 commented Dec 19, 2022

Thanks @panbanda. I am not aware or skaffold up do yo mean skaffold dev?

@anthonyalayo
Copy link

anthonyalayo commented Jun 14, 2023

I have the same issue. Skaffold render shows all the secrets as encrypted. Can this be fixed? Ideally useHelmSecrets would have had them decrypted.

@anthonyalayo
Copy link

Can anyone from the skaffold team chime in?

@anthonyalayo
Copy link

@aaron-prindle @tejal29 If someone could point me to where the change needs to happen, I could also give it a shot. Is there anyone around that would know?

@anthonyalayo
Copy link

Thanks @ericzzzzzzz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/render deploy/helm kind/bug Something isn't working priority/p2 May take a couple of releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants