Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom class that extends from OL.Layer.WMS for the map layers #82

Open
Glodenox opened this issue Jun 9, 2020 · 0 comments
Open
Assignees

Comments

@Glodenox
Copy link
Owner

Glodenox commented Jun 9, 2020

Instead of trying to shoehorn the necessary functionality in from the outside of the OpenLayers.Layer.WMS class, it would make a lot more sense to inherit from the object and add a bunch of the functionality in there.

This would definitely make the tile manipulation a lot less demanding as we can just use canvas elements instead of imgs. It would also make retrieving the error messages possible directly instead of having to call the service again, which would allow the removal of all @connect headers added in #12. And on top of that, it would also allow for a clean solution for the issues encountered in #23 as Proj4js possibly wouldn't need to be exposed to the rest of OpenLayers for it to work.

This would be a major refactoring for the better.

@Glodenox Glodenox self-assigned this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant