Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical text files not loading #42

Open
calebschipplock opened this issue Mar 1, 2020 · 7 comments
Open

Numerical text files not loading #42

calebschipplock opened this issue Mar 1, 2020 · 7 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@calebschipplock
Copy link

I had trouble getting the script to work with textfiles that contained numberic characters as the file name.

@robtoyota
Copy link
Contributor

@calebschipplock Can you provide the file name that you were using? Or even the file itself, if you're comfortable with uploading that here? I'm unable to reproduce the problem with file names like #hello123.text, or #123hello.txt, or #123.txt.

Additionally, does the prompt window that runs text-script display any errors?

Disclaimer: I'm not the developer, but this information will be very helpful in troubleshooting.

@calebschipplock
Copy link
Author

Cheers for your comments Rob!
I just figured out what the issue is, it only occurs when I use the numpad to type "#12345". If i use the keys above qwerty the script runs as intended.

No errors were displayed in the window.
#12345.txt

@GeorgeCiesinski
Copy link
Owner

Hello @calebschipplock , thanks for the report, and for posting your solution. I'll have to see why the numpad keys are registering differently from the regular number keys and try to correct this.

@GeorgeCiesinski GeorgeCiesinski self-assigned this Mar 1, 2020
@GeorgeCiesinski GeorgeCiesinski added this to the 1.3.1 Bugfix milestone Mar 1, 2020
@GeorgeCiesinski GeorgeCiesinski added the bug Something isn't working label Mar 1, 2020
@robtoyota
Copy link
Contributor

Thanks @calebschipplock. Good troubleshooting. I can reproduce the problem and know what's wrong, so I'll correct it and send a pull request for the version 1.3.1 release next week.

@robtoyota robtoyota mentioned this issue Mar 5, 2020
9 tasks
@GeorgeCiesinski
Copy link
Owner

Fixed in pull request: #51. This fix is going to be part of the 1.3.1 hotfix releasing at the end of the week.

@GeorgeCiesinski
Copy link
Owner

GeorgeCiesinski commented Mar 10, 2020

Reopening issue. I caught a bug where the Linux build was completely broken. We will have to move this to a new hotfix as it will require more research to complete.

Posting the commit where this change was implemented here.

@GeorgeCiesinski
Copy link
Owner

This is related to issue #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants