Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GAlert/GitAlert/QuitAlert: duplicated code #445

Open
jackburton79 opened this issue Oct 22, 2024 · 2 comments
Open

GAlert/GitAlert/QuitAlert: duplicated code #445

jackburton79 opened this issue Oct 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jackburton79
Copy link
Collaborator

GAlert, QuitAlert and GitAlert have a lot of code in common.
They are also use a lot of BAlert code.

We should try to do some refactor to reduce code duplication
@jackburton79 jackburton79 added the enhancement New feature or request label Oct 22, 2024
@nexus6-haiku
Copy link
Collaborator

I agree, unfortunately BAlert can’t be extended so we may need to rewrite GAlert to be as much general as possible especially when it comes to managing buttons and validation rules.

@jackburton79
Copy link
Collaborator Author

Yeah that's the idea I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackburton79 @nexus6-haiku