Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce / improve active zone for the tab close button #265

Open
jackburton79 opened this issue Jan 4, 2024 · 3 comments
Open

Reduce / improve active zone for the tab close button #265

jackburton79 opened this issue Jan 4, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jackburton79
Copy link
Collaborator

The active zone for the tab close button is too big, as shown in the screenshot.
screenshot

@Freaxed
Copy link
Collaborator

Freaxed commented Jan 4, 2024

Linked with this also we should find a way to avoid start dragging a tab when pressing the close button. Dragging with the X icon cause the tab to be dragged but then when released it closes.

@jackburton79
Copy link
Collaborator Author

I had a look at the code, and debugged a bit:
It seems there's something wrong in the logic of WebTabView::_DrawCloseButton() and WebTabView::_CloseRectFrame():

The frame passed to _DrawCloseButton() is passed directly to _CloseRectFrame(), but it's not supposed to be the frame of the button.
Moreover: I printed the values of the frame and they change in a way I don't understand yet.
Needs to be reviewed

@jackburton79 jackburton79 self-assigned this Jan 8, 2024
@jackburton79
Copy link
Collaborator Author

I tried to fix the problem, but I failed.
By the way, this code is taken from Webpositive which has the same problem.

I opened a ticket there: https://dev.haiku-os.org/ticket/18741

@nexus6-haiku nexus6-haiku added the enhancement New feature or request label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants