Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success threshold should be greater_than_or_equal #10

Open
alanman opened this issue Feb 7, 2018 · 1 comment
Open

Success threshold should be greater_than_or_equal #10

alanman opened this issue Feb 7, 2018 · 1 comment

Comments

@alanman
Copy link

alanman commented Feb 7, 2018

!roll 5d10 >> 6

When I roll this, I read it as roll 5d6, difficulty 6.
RPBot reads it as 5d6, difficulty 7

My understanding is the difficulty should be greater than or equal, not just greater than.

Same goes for the other difficulty measure: !roll 1d20 > 10 will grant success at 11 or higher instead of at the expected 10.

For better logic and understanding, I request this change be made.

@alanman
Copy link
Author

alanman commented Feb 12, 2018

Submitted a pull request with the changes.
#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant