Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Created By field to ship infobox #91

Open
cswimr opened this issue Jan 8, 2025 · 1 comment
Open

Add Created By field to ship infobox #91

cswimr opened this issue Jan 8, 2025 · 1 comment
Labels
site:shortcodes Concerns shortcodes

Comments

@cswimr
Copy link
Member

cswimr commented Jan 8, 2025

Is your feature request related to a problem? Please describe.
Some people used the old Galaxypedia almost exclusively for checking who made a specific ship model. We currently don't expose that information in the infobox anymore, because Galaxy Info doesn't provide it. I don't think this should be Galaxy Info's job, so we should keep track of it ourselves.

Describe the solution you'd like
We should add a manually provided parameter to the shipinfobox shortcode that shows who created a ship model.

Describe alternatives you've considered
We could just have this information in Trivia, but I generally think the infobox is a better option.

Additional context
Thanks @Wingysam for the idea.

@cswimr cswimr added the site:shortcodes Concerns shortcodes label Jan 8, 2025
@smallketchup82
Copy link
Member

i'll be frank and say that 1. im saying this between sleep cycles and 2. there's way more parameters missing from the hugopedia infobox than just the created by field

i'd appreciate maybe making a new issue to house discussions over which parameters we'd want to keep, which we'd want to throw away, and make this a sub issue of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site:shortcodes Concerns shortcodes
Projects
None yet
Development

No branches or pull requests

2 participants