Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: You can spam select a song in the freeplay menu #3562

Open
2 tasks done
Hundrec opened this issue Oct 4, 2024 · 7 comments
Open
2 tasks done

Bug Report: You can spam select a song in the freeplay menu #3562

Hundrec opened this issue Oct 4, 2024 · 7 comments
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.

Comments

@Hundrec
Copy link
Contributor

Hundrec commented Oct 4, 2024

Issue Checklist

  • I have properly named my issue
  • I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

0.5.1

Description (include any images, videos, errors, or crash logs)

On songs with alternate instrumentals, you can spam the select key. Boyfriend's new character animation doesn't affect this behavior.

This one honestly makes me chuckle.

Fresh

FRESH.mp4

Monster

Monster.mp4

Steps to Reproduce

  1. Enter the Freeplay menu
  2. Select a BF song that has a Pico remix
  3. Spam Enter
@Hundrec Hundrec added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Oct 4, 2024
@amyspark-ng
Copy link
Contributor

kinda working on this

@AbnormalPoof
Copy link
Contributor

AbnormalPoof commented Oct 7, 2024

You can also spam the character select transition if you spam fast enough.

@amyspark-ng
Copy link
Contributor

should be an easy fix
https://github.com/FunkinCrew/Funkin/blob/main/source/funkin/ui/freeplay/FreeplayState.hx#L1759

should simply be replaced with

    if (accepted && !busy)
    {
      busy = true;
      grpCapsules.members[curSelected].onConfirm();
    }

but for some reason it's not working for me!!!!

same with the character select transition!

@amyspark-ng
Copy link
Contributor

is even the more weird because onConfirm() will call another function that sets busy to true, so the !busy condition would work, that's so weird

@amyspark-ng
Copy link
Contributor

for the life of me i can't seem to fix this

@AbnormalPoof
Copy link
Contributor

#3866 fixes this

@amyspark-ng
Copy link
Contributor

i once tried to fix it but struggled, glad it'll be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

3 participants