diff --git a/.github/ct-install.yaml b/.github/ct-install.yaml deleted file mode 100644 index 0671785ef00731..00000000000000 --- a/.github/ct-install.yaml +++ /dev/null @@ -1,16 +0,0 @@ -chart-dirs: - - bitnami -chart-repos: - - bitnami=https://charts.bitnami.com/bitnami -debug: true -excluded-charts: - - common - - kubeapps - - kibana - - kong - - mariadb-galera - - ejbca - - wavefront - - dataplatform-bp1 - - dataplatform-bp2 -remote: origin diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml deleted file mode 100644 index 67085e1c294bfa..00000000000000 --- a/.github/workflows/lint-test.yaml +++ /dev/null @@ -1,23 +0,0 @@ -name: Test Charts - -on: pull_request - -jobs: - test: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v2 - - - name: Fetch history - run: git fetch --prune --unshallow - - - name: Set up chart-testing - uses: helm/chart-testing-action@v2.1.0 - - - name: Create kind cluster - uses: helm/kind-action@v1.2.0 - - - name: Run chart-testing (install) - run: ct install --config .github/ct-install.yaml - diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4379e4667510a0..b773d867b60c2a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -51,15 +51,14 @@ Notice the `Author` and `Signed-off-by` lines match. If they don't your PR will ### PR Approval and Release Process -1. Changes are automatically linted and tested using the [`ct` tool](https://github.com/helm/chart-testing) as a [GitHub action](https://github.com/helm/chart-testing-action). Those tests are based on `helm install`, `helm lint` and `helm test` commands and provide quick feedback about the changes in the PR. For those tests, the chart is installed on top of [kind](https://github.com/kubernetes-sigs/kind) and this step is not blocking (as opposed to 3rd step). 1. Changes are manually reviewed by Bitnami team members. -1. Once the changes are accepted, the PR is verified with a [Static analysis](https://github.com/bitnami/charts/blob/master/TESTING.md#Static-analysis) that includes the lint and the vulnerability checks. If that passes, the Bitnami team will review the changes and trigger the verification and functional tests. +1. Once the changes are accepted, the PR is verified with a [Static analysis](https://github.com/bitnami/charts/blob/master/TESTING.md#Static-analysis) that includes the lint and the vulnerability checks. If that passes, the Bitnami team will review the changes and trigger the verification and functional tests. 1. When the PR passes all tests, the PR is merged by the reviewer(s) in the GitHub `master` branch. 1. Then our CI/CD system is going to push the chart to the Helm registry including the recently merged changes and also the latest images and dependencies used by the chart. The changes in the images will be also committed by the CI/CD to the GitHub repository, bumping the chart version again. ***NOTE***: Please note that, in terms of time, may be a slight difference between the appearance of the code in GitHub and the chart in the registry. -### Testing +### Testing 1. Read the [Test Strategy](https://github.com/bitnami/charts/blob/master/TESTING.md) guide. 2. Determine the types of tests you will need based on the chart you are testing and the information in the test strategy.