Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply provider-specific validation templates to work #22

Open
meilinger opened this issue Jun 2, 2015 · 2 comments
Open

Apply provider-specific validation templates to work #22

meilinger opened this issue Jun 2, 2015 · 2 comments

Comments

@meilinger
Copy link
Member

Might fragment some of the validation logic, but will expose issues up-front vs potential failures downstream

@garnertb
Copy link
Contributor

garnertb commented Jun 2, 2015

So far, the validation seems provider-specific (ie https://github.com/FireCARES/harvester/blob/master/harvester/validators.py#L4 seems related to https://github.com/FireCARES/harvester/blob/master/harvester/providers/esri.py#L26). Maybe we just add a is_valid method to each provider? Am I missing something?

@meilinger
Copy link
Member Author

This was more meant as a way to validate required fields in the work templates (based on specific providers)...might be overkill since we're falling-back to kwarg default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants