Write tests for functions that call send

[Fethbita]

Using test vectors and by mocking the send or card.transmit functions, unit tests for functions that call the send function can be written. However mocking a pcsc::Card proved to be difficult, an issue is created in pcsc GitHub: bluetech/pcsc-rust#50.

The functions that can get unit tests after this are:

• read_data_from_ef,
• establish_bac_session_keys,
• Protected APDU creation or parsing of the send function,
• process_secure_rapdu.

[dishmaker]

I think you can create a trait like:

pub trait MrtdCard {

    /// Returns answer to reset
    fn atr(&self) -> Result<Vec<u8>>

    /// Returns R-APDU including 2 bytes SW
    fn transmit(&self, c_apdu: &[u8]) -> Result<Vec<u8>>


}

so that your wrapper takes a generic param:

pub struct EmrtdComms<C: MrtdCard> {
    // ...
}

impl<C: MrtdCard> EmrtdComms<C> {
    // ...

}

[Fethbita]

Thank you for the tip @dishmaker. Implemented this solution in #4, also implementing a trait based solution for the Rng.