-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update 13-How-to-edit-wiki.md with first learnings from #142 #144
Comments
That's an overstatement, current instructions look fine |
Did you consider the "version change" scenario when the comment was made? |
I don't see correlation between broken links and different method of installing Node.js dependencies, and in your case, change installed in dependencies Please note that current docs already mention when to "re-install" dependencies:
However, I was able to reproduce your no warning state, and it looks like a Docusaurus weird behavior (it shows warnings only on rebuilds) which is improved by #147 |
Note that this will only check will always fail when file does not exist: [ETB PID and Autotune](/07-Advanced-Features/ETB/ETB-PID.md) it won't validate regular links will only fail during the build when link does not work: [ETB PID and Autotune](/Advanced-Features/ETB/ETB-PID) since they are not crawled before building ( I can see that now we use both markdown links and regular links |
Sorry, not sure which name above refers to which type of link :( Did we not come across this minor but annoying difference previously? I seem to remember so. And actually I was surprised that only the previously existing link "/Advanced-Features/ETB/ETB-PID.md" required the number prefix, while all others did NOT. |
is the preferred approach in combination with "numbered prefix", right? |
@karniv00l could you please comment on above question? |
Sure, I did a little refactor to make it more clear Regarding |
@karniv00l The suggested approach (validateRelativeUrls(files);) would from my view not have the best performance due to multiple reads of all files. |
sure |
Current instructions for https://wiki.fome.tech/How-to-edit-wiki/#how-to-test-your-changes are incomplete/wrong
See #142 (comment) for details
The text was updated successfully, but these errors were encountered: