You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Getters accept limit and offset parameters, which does not encourage the client to implement API pagination properly. For example, in the codebase for ChRIS_ui and chris_ui_ssr we see in many places where {limit: 100*} is given as a parameter.
This practice causes performance problems and code quality issues (pagination parameters are often specified in the code where pagination is not relevant in the context)
My suggestion is to provide an iterator (async iterable, stream, whatever it's called) based interface similar to how it is implemented in aiochris and the rust chris client.
Getters accept
limit
andoffset
parameters, which does not encourage the client to implement API pagination properly. For example, in the codebase for ChRIS_ui and chris_ui_ssr we see in many places where{limit: 100*}
is given as a parameter.This practice causes performance problems and code quality issues (pagination parameters are often specified in the code where pagination is not relevant in the context)
My suggestion is to provide an iterator (async iterable, stream, whatever it's called) based interface similar to how it is implemented in aiochris and the rust chris client.
https://fnndsc.github.io/aiochris/v0.4.0/aiochris.html#Search
The text was updated successfully, but these errors were encountered: