Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single quote rule is not enforced #296

Open
jennydaman opened this issue Oct 14, 2022 · 2 comments
Open

Single quote rule is not enforced #296

jennydaman opened this issue Oct 14, 2022 · 2 comments
Assignees
@Seundede
Labels
good first issue Good for newcomers refactor Code cleanup and upgrades which do not affect features.

Comments

@jennydaman
Copy link
Collaborator

ChRIS_store_ui/.eslintrc

Lines 4 to 5 in 51bb766

"airbnb",
"prettier"

I thought configuring eslint to use airbnb and prettier style would enforce common rules such as single quotes but it doesn't seem to work. It is necessary to revisit our eslint config, make sure it's as strict as possible, and also we should update the eslint packages.
@jennydaman jennydaman added good first issue Good for newcomers refactor Code cleanup and upgrades which do not affect features. labels Oct 14, 2022
@Seundede
Copy link
Contributor

Can this be assigned to me?

@Seundede
Copy link
Contributor

#297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Seundede Seundede

Labels
good first issue Good for newcomers refactor Code cleanup and upgrades which do not affect features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jennydaman @Seundede