Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Mark Watched Replays with Visual Indicators #3240

Open
magge-faf opened this issue Aug 28, 2024 · 5 comments · May be fixed by #3293
Open

[Feature]: Mark Watched Replays with Visual Indicators #3240

magge-faf opened this issue Aug 28, 2024 · 5 comments · May be fixed by #3293

Comments

@magge-faf
Copy link
Collaborator

Is your feature request related to a problem?

Losing track of which replays have already been watched.

Describe the solution you'd like

It would be a nice QOL improvement if watched replays were marked with an icon, different shade of color, watched-date/time or an outline to indicate they have already been viewed.

E.g.:

image

Describe alternatives you've considered

A simple checkmark-icon or watched-tag

@Brutus5000
Copy link
Member

Should this be saved locally (per installation) or server side?

@magge-faf
Copy link
Collaborator Author

For easier and faster implementation, I suggest doing it locally for now. If the QOL feature gains more appeal, it can always be refactored to work with the server.

@sulikdan
Copy link
Contributor

sulikdan commented Jan 6, 2025

@Sheikah45 gonna take look at this one, but an question here.

I'm planning to use something like - Set<Replay_id, {replay_id, list watchedDates}> , though question is - was there something similarly implemented -> e.g. saved locally and read afterwards. Some sort of service? (I don't it belong to prefs) Is there a service that I could follow for this feature? Any tips(keyword are enough)? Otherwise I thinking about inventing a wheel again 🚀

@Sheikah45
Copy link
Member

I actually do think the best place is probably in the prefs maybe or I guess it could be some other json persistent file that just contains the dates and replay IDs.

There isn't currently any service that stores purely client side persistent state like this besides the preferences.

@Sheikah45
Copy link
Member

Where it would go is probably just in the replay service or replay runner

@sulikdan sulikdan linked a pull request Jan 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@Brutus5000 @sulikdan @Sheikah45 @magge-faf and others