-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments #121
Comments
Thanks for the suggestions, could you clarify the second point? I'm not totally sure what you mean. |
I will say, it's not our fault if our users can't spell ;) |
re the second point, I mean you should reply inside the callback that fires after the database request has returned. Otherwise you may redirect (so the user thinks everything is fine), then suddenly an error is thrown when the db returns. |
For point 5;
Could you recommend any resources on learning good naming conventions? |
Consistency is the key. It doesn't matter what the convention is. The only thing to be aware of is that capital letters will be ignored by some operating systems so should be avoided. |
Nice work. Well done for getting it hosted. Some comments:
forEach
instead ofmap
here. And here.The text was updated successfully, but these errors were encountered: