Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandamp rate limiting causing files not to download #30

Open
demize opened this issue Jan 20, 2022 · 5 comments
Open

Bandamp rate limiting causing files not to download #30

demize opened this issue Jan 20, 2022 · 5 comments

Comments

@demize
Copy link

demize commented Jan 20, 2022

Bandcamp appears to have implemented some sort of aggressive rate limiting on their end that causes problems with bandcamp-collection-downloader; after a few releases are downloaded, Bandcamp starts returning 429 Too Many Requests instead of files, and the downloads fail.

The most effective way of combating this may be to implement exponential backoff on 429 errors such that all albums end up downloaded without making Bandcamp too angry; as it is, large portions of your library fail to download because the current retry method is too quick.

@roxaloxa
Copy link

roxaloxa commented Feb 5, 2022

Any traction on this? Running into it now as well

@Ezwen
Copy link
Owner

Ezwen commented Feb 6, 2022

Thanks for the report. Indeed that's an issue. I haven't encountered it yet, but I should run some tests to see if I can reproduce it.

If anyone wants to try a fix, PRs are of course welcome − I don't know when I will have time to make the fix :/

@roxaloxa
Copy link

roxaloxa commented Feb 7, 2022

@Ezwen I always hit it somewhere around 20 downloads, everything after failed with code 429. I just kept running the script until my entire collection synced, and now I doubt I'll ever hit it again as I likely won't buy more than 20 albums at once haha. So it's weird in that it shouldn't happen often... but likely guaranteed to happen immediately on first time use?

@FabioLolix
Copy link

Hello, I have installed the program earlier today, seeing this issue I have set the number of jobs to 1, I'm at download N° 118 without problems so far

@thegass
Copy link
Contributor

thegass commented Oct 24, 2024

this fixes the problem for me #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants