Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Download updated collection items if older item exists in cache #24

Open
jdheyburn opened this issue Apr 10, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jdheyburn
Copy link

This is a follow on from #23.

Bandcamp allows artists to update releases over time. One particular release has been "enhanced" with additional tracks and has a change of name.

https://zakedrone.bandcamp.com/album/carolina-coppice-movements

This used to be called "Coppice Movements" and was available at the below URL, which actually now redirects to the URL above.

https://zakedrone.bandcamp.com/album/coppice-movements

This release has an ID of r113190241 and the old version was downloaded and exists in the cache file like this:

r113190241| "Coppice Movements" (2020) by zakè

Because of it existing in the cache it does not attempt to make a call to Bandcamp to download the newer version. It would be helpful to have the downloader check to see if what is already downloaded is indeed the most recent version of a release.

Thanks!

@Ezwen
Copy link
Owner

Ezwen commented Oct 11, 2021

Very relevant indeed, even without #23. If artists can update releases, then updating releases would make sense. The question is how can we efficiently detect that a release has been updated? I'll have to look into that.

Another question is: what should we do if an artist deletes tracks? Should we keep them, or make the "update" also delete tracks? Tough one.

@Ezwen Ezwen added the enhancement New feature or request label Oct 13, 2021
@Ezwen
Copy link
Owner

Ezwen commented Mar 13, 2022

There seems to be a dateModified information attached to each release. If we store in the cache file the download date of each release, then we should be able to detect updates and trigger a re-download.

However, this would most likely be achieved with a specific flag, as this will require re-downloading the metadata of all releases, which is quite slow (and which led us to have this cache file in the first place).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants