Added support for phone mention without expensify.sms suffix
#645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
deetergp
approved these changes
Feb 8, 2024
|
@deetergp I forgot to change this comment shall I raise another PR? expensify-common/lib/ExpensiMark.js Lines 160 to 161 in c0d4a94 |
c3024
reviewed
Feb 9, 2024
| /** | ||
| * Regex matching a text containing an e164 format phone number | ||
| */ | ||
| readonly PHONE_PART: "\\+?[1-9]\\d{1,14}"; |
There was a problem hiding this comment.
Shouldn't this be in the CONST.jsx file?
|
ah shoot @deetergp we probably shouldn't have merged this without any testing steps or test screenshots 😟 |
|
Confirmed locally that this does not work :( |
|
Gonna spin up a revert |
|
Yikes, that's my bad 😬 Thanks for putting up the revert @jasperhuangg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will introduce support for phone mention without
expensify.smssuffix.@c3024 @jasperhuangg
One question I have is now I have not made
+sign to be mandatory in the beginning of the mention but we can make it mandatory. Need your thoughts on this.Fixed Issues
$ Expensify/App#33902
Tests
QA